From f1ff45d870319fcb27463364bdba65bdd419727f Mon Sep 17 00:00:00 2001 From: Daniel Price Date: Wed, 24 Jun 2026 16:45:40 +1000 Subject: [PATCH 1/2] (build) compile without warnings with gfortran v16 --- src/convert_grid.f90 | 2 +- src/labels.f90 | 6 +++--- src/read_data_dragon.f90 | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/convert_grid.f90 b/src/convert_grid.f90 index 5291b966..f14b631a 100644 --- a/src/convert_grid.f90 +++ b/src/convert_grid.f90 @@ -737,7 +737,7 @@ subroutine get_splash2grid_options(ndim,ncolstogrid,icoltogrid,isperiodic,xlab) integer, intent(in) :: ndim integer, intent(out) :: ncolstogrid,icoltogrid(:) logical, intent(out) :: isperiodic(3) - character(len=1), intent(in) :: xlab(3) + character(len=*), intent(in) :: xlab(3) integer :: nstring,i,icol logical :: dens_only character(len=30), dimension(12) :: strings diff --git a/src/labels.f90 b/src/labels.f90 index 00514540..f8a6668a 100644 --- a/src/labels.f90 +++ b/src/labels.f90 @@ -337,9 +337,9 @@ end function shortstring !----------------------------------------------------------------- elemental function shortlabel(string,unitslab,lc) use asciiutils, only:string_delete,lcase - character(len=lenlabel), intent(in) :: string - character(len=*), intent(in), optional :: unitslab - character(len=lenlabel) :: shortlabel + character(len=*), intent(in) :: string + character(len=*), intent(in), optional :: unitslab + character(len=lenlabel) :: shortlabel logical, intent(in), optional :: lc if (present(unitslab)) then diff --git a/src/read_data_dragon.f90 b/src/read_data_dragon.f90 index 5664e1fa..882d5bdc 100644 --- a/src/read_data_dragon.f90 +++ b/src/read_data_dragon.f90 @@ -753,7 +753,7 @@ subroutine find_weights(out_unit_interp,out_unitzintegration,out_labelzintegrati real(doub_prec), intent(out) :: out_unit_interp real, intent(out) :: out_unitzintegration - character(len=20), intent(out) :: out_labelzintegration + character(len=*), intent(out) :: out_labelzintegration real(doub_prec) :: dm_unit, dh_unit, drho_unit, dr_unit logical :: do_dimweight, do_zintegration character(len=20) :: rho_length_label From d4b16f6599eb2e237919613a4efb10be61d890d6 Mon Sep 17 00:00:00 2001 From: Daniel Price Date: Wed, 24 Jun 2026 16:55:28 +1000 Subject: [PATCH 2/2] (labels) fix gemini comments --- src/labels.f90 | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/labels.f90 b/src/labels.f90 index f8a6668a..86be6121 100644 --- a/src/labels.f90 +++ b/src/labels.f90 @@ -284,9 +284,9 @@ end function get_z_coord ! !----------------------------------------------------------------- elemental function strip_units(string,unitslab) - character(len=lenlabel), intent(in) :: string - character(len=*), intent(in) :: unitslab - character(len=lenlabel) :: strip_units + character(len=*), intent(in) :: string + character(len=*), intent(in) :: unitslab + character(len=lenlabel) :: strip_units integer :: ipos strip_units = string @@ -310,9 +310,9 @@ end function strip_units !----------------------------------------------------------------- elemental function shortstring(string,unitslab) use asciiutils, only:string_delete - character(len=lenlabel), intent(in) :: string - character(len=*), intent(in), optional :: unitslab - character(len=lenlabel) :: shortstring + character(len=*), intent(in) :: string + character(len=*), intent(in), optional :: unitslab + character(len=lenlabel) :: shortstring shortstring = string !--strip off the units label