Snippets showing up on enum constant declaration position

[FMorschel]

Repro:

enum MyEnum {
  v(),
  ^
  ;

  const MyEnum();
}

If you request completion at ^, you'll see:

Since we are in an enum-constant declaration scope (where we write the enum constant name), these should not show up. I'm not sure what the exact AST node we are here, but I believe this may be fixable.

CC @DanTup

[DanTup]

@FMorschel those snippets don't look like snippets we have in the server - are you sure they're not coming from somewhere else?

[DanTup]

Are you using https://marketplace.visualstudio.com/items?itemName=nash.awesome-flutter-snippets?

It appears to have these snippets:

https://github.com/Nash0x7E2/awesome-flutter-snippets/blob/master/snippets/snippets.json

But they are just defined locally and have no language context, so I think they will show up everywhere and we can't affect that from the LSP server.

[FMorschel]

Oh, yes. Sorry, they were coming from: https://marketplace.visualstudio.com/items?itemName=Nash.awesome-flutter-snippets.

But we still have fun showing up at that position:

[DanTup]

Great, thanks - I'll take a look at that. I also see switch and switch expression in a top level const x = that seem wrong. Thanks!

[FMorschel]

Adding here. As I noted at #62170 (comment):

1. There is no parameter request here
2. Closures aren't allowed in constant contexts

Similar to the above, but inside the parameter list instead.

[DanTup]

I think https://dart-review.googlesource.com/c/sdk/+/467022 fixes all of these.