LightButton compile for Rack 2.4.1

[jackokring]

Due to the SDK now having LightButton the following kind of thing occurs.

src/EO1.cpp:436:2: error: reference to ‘LightButton’ is ambiguous
  436 |  LightButton *paramRun;
      |  ^~~~~~~~~~~
In file included from ../../include/rack.hpp:36,
                 from src/SubmarineFree.hpp:1,
                 from src/EO1.cpp:5:
../../include/componentlibrary.hpp:890:8: note: candidates are: ‘template<class TBase, class TLight> struct rack::componentlibrary::LightButton’
  890 | struct LightButton : TBase {
      |        ^~~~~~~~~~~
In file included from src/SubmarineFree.hpp:122,
                 from src/EO1.cpp:5:
src/shared/components.hpp:96:8: note:                 ‘struct LightButton’
   96 | struct LightButton : app::Switch {
      |        ^~~~~~~~~~~

This results in a make error.

[neoh4x0r]

I think the easiest way to resolve this is to put the Submarine code into it's own explicit namespace, which will avoid type collisions, and for corner/edge-cases you can explicitly use the namespace sbf::components::<TYPE>.

For example, putting LightButton into the namespace sbf::components, and then in EO1.cpp (and others) you could add using namespace sbf::components; and use sbf::components::LightButton.

Another, probably simpler solution, would be to rename LightButton to something else and a simple text replacement can be used to rename all the usages of it -- the only potential issue I see is maybe it could possibly break patches that were using the old version and type name.