From 44af264bfa0777d00539194ec96ec90899f871c8 Mon Sep 17 00:00:00 2001
From: davidohnee <davidohnee@gmail.com>
Date: Sat, 3 Oct 2026 17:04:31 +0200
Subject: [PATCH] address sonarqube findings

---
 src/components/IconComboContextMenu.vue       |  6 ++++
 src/components/IconContextMenu.vue            |  3 ++
 src/components/MatchCard.vue                  |  3 ++
 src/components/MatchRow.vue                   |  3 ++
 src/components/StepProgress.vue               |  3 ++
 src/components/TournamentMatches.vue          |  6 ++++
 .../modals/ShareFull/FoldableShareOption.vue  |  3 ++
 .../notifications/ClosableNotification.vue    |  3 ++
 .../notifications/YesNoNotification.vue       |  9 ++++++
 src/components/share/GistConfig.vue           |  6 ++--
 src/helpers/common.ts                         |  2 +-
 src/helpers/share/gist/gist.ts                |  2 +-
 src/helpers/share/gist/pullSync.ts            |  2 +-
 src/helpers/share/index.ts                    |  2 +-
 src/helpers/share/p2p/pullSync.ts             |  6 ++--
 src/helpers/share/p2p/pushSync.ts             |  8 +++---
 src/pages/settings/general/appearance.vue     |  3 ++
 src/stores/persistence/indexedDb.ts           | 28 ++++++++++---------
 src/views/create/BasicsView.vue               |  3 ++
 src/views/create/TemplateView.vue             |  6 ++++
 20 files changed, 79 insertions(+), 28 deletions(-)

diff --git a/src/components/IconComboContextMenu.vue b/src/components/IconComboContextMenu.vue
index 3405471..4e4611b 100644
--- a/src/components/IconComboContextMenu.vue
+++ b/src/components/IconComboContextMenu.vue
@@ -60,6 +60,12 @@ const groups = computed(() => {
                         option.action();
                         close();
                     "
+                    @keydown.enter="
+                        option.action();
+                        close();
+                    "
+                    tabindex="0"
+                    role="button"
                 >
                     <slot
                         v-if="$slots.item"
diff --git a/src/components/IconContextMenu.vue b/src/components/IconContextMenu.vue
index 4cf3964..49ea8e2 100644
--- a/src/components/IconContextMenu.vue
+++ b/src/components/IconContextMenu.vue
@@ -137,7 +137,10 @@ onBeforeUnmount(() => {
     >
         <div
             class="activator"
+            role="button"
+            tabindex="0"
             @click.stop="toggle"
+            @keydown.enter="toggle"
         >
             <slot
                 name="activator"
diff --git a/src/components/MatchCard.vue b/src/components/MatchCard.vue
index 9cba866..8cdd553 100644
--- a/src/components/MatchCard.vue
+++ b/src/components/MatchCard.vue
@@ -99,8 +99,11 @@ const teamLost = (team: MatchTeam) => {
     />
     <div
         class="match card"
+        role="button"
+        tabindex="0"
         :class="{ readonly }"
         @click="openMatchEditor"
+        @keydown.enter="openMatchEditor"
     >
         <div
             class="team"
diff --git a/src/components/MatchRow.vue b/src/components/MatchRow.vue
index 5b5025c..c0ed283 100644
--- a/src/components/MatchRow.vue
+++ b/src/components/MatchRow.vue
@@ -93,8 +93,11 @@ watch(
     />
     <div
         class="match row"
+        role="button"
+        tabindex="0"
         :class="{ readonly }"
         @click="openMatchEditor"
+        @keydown.enter="openMatchEditor"
     >
         <div class="time-progress">
             <span
diff --git a/src/components/StepProgress.vue b/src/components/StepProgress.vue
index 74c2fd1..008003b 100644
--- a/src/components/StepProgress.vue
+++ b/src/components/StepProgress.vue
@@ -28,6 +28,8 @@ const jumpTo = (index: number) => {
                 <div class="step">
                     <div
                         class="circle"
+                        role="button"
+                        tabindex="0"
                         :class="{
                             done: index < modelValue,
                             active: index === modelValue,
@@ -37,6 +39,7 @@ const jumpTo = (index: number) => {
                                 (canGoBack && index < modelValue),
                         }"
                         @click="jumpTo(index)"
+                        @keydown.enter="jumpTo(index)"
                     ></div>
                     <span>{{ name }}</span>
                 </div>
diff --git a/src/components/TournamentMatches.vue b/src/components/TournamentMatches.vue
index d318e33..5f43bdf 100644
--- a/src/components/TournamentMatches.vue
+++ b/src/components/TournamentMatches.vue
@@ -218,8 +218,11 @@ onMounted(() => {
                     :key="option"
                     :value="option"
                     class="chip-option"
+                    role="button"
+                    tabindex="0"
                     :class="{ selected: selectedGroupOption === option }"
                     @click="selectedGroupOption = option"
+                    @keydown.enter="selectedGroupOption = option"
                 >
                     by {{ getFriendlyOptionName(option) }}
                 </div>
@@ -239,8 +242,11 @@ onMounted(() => {
                 </div>
                 <div
                     class="filter"
+                    role="button"
+                    tabindex="0"
                     :class="{ open: matchFilter?.contextMenu?.isOpen }"
                     @click.stop.prevent="matchFilter?.contextMenu?.toggle()"
+                    @keydown.enter.prevent="matchFilter?.contextMenu?.toggle()"
                 >
                     <MatchFilter
                         ref="matchFilter"
diff --git a/src/components/modals/ShareFull/FoldableShareOption.vue b/src/components/modals/ShareFull/FoldableShareOption.vue
index efb9518..95357eb 100644
--- a/src/components/modals/ShareFull/FoldableShareOption.vue
+++ b/src/components/modals/ShareFull/FoldableShareOption.vue
@@ -18,7 +18,10 @@ const expanded = ref(false);
     <div class="option">
         <div
             class="header"
+            role="button"
+            tabindex="0"
             @click="expanded = !expanded"
+            @keydown.enter="expanded = !expanded"
         >
             <ion-icon :name="expanded ? 'chevron-down' : 'chevron-forward'"></ion-icon>
             <h3>{{ title }}</h3>
diff --git a/src/components/notifications/ClosableNotification.vue b/src/components/notifications/ClosableNotification.vue
index aa1dee7..3423c22 100644
--- a/src/components/notifications/ClosableNotification.vue
+++ b/src/components/notifications/ClosableNotification.vue
@@ -43,8 +43,11 @@ const click = () => {
             'cursor-pointer':
                 (notification.type !== 'redirect' && notification.redirect) || notification.onClick,
         }"
+        role="button"
+        tabindex="0"
         class="notification"
         @click.stop.prevent="click"
+        @keydown.enter="click"
     >
         <div class="message">
             <h4>
diff --git a/src/components/notifications/YesNoNotification.vue b/src/components/notifications/YesNoNotification.vue
index c2d67d9..186577a 100644
--- a/src/components/notifications/YesNoNotification.vue
+++ b/src/components/notifications/YesNoNotification.vue
@@ -46,6 +46,9 @@ const click = () => {
 <template>
     <div
         class="notification"
+        role="button"
+        tabindex="0"
+        @keydown.enter="click"
         @click.stop.prevent="click"
     >
         <div class="message">
@@ -62,13 +65,19 @@ const click = () => {
         <div class="yes-no">
             <div
                 class="yes option"
+                role="button"
+                tabindex="0"
                 @click.stop.prevent="yes"
+                @keydown.enter.stop.prevent="yes"
             >
                 <ion-icon name="checkmark-outline"></ion-icon>
             </div>
             <div
                 class="no option"
+                role="button"
+                tabindex="0"
                 @click.stop.prevent="no"
+                @keydown.enter.stop.prevent="no"
             >
                 <ion-icon name="close-outline"></ion-icon>
             </div>
diff --git a/src/components/share/GistConfig.vue b/src/components/share/GistConfig.vue
index d19ccac..3541c2f 100644
--- a/src/components/share/GistConfig.vue
+++ b/src/components/share/GistConfig.vue
@@ -26,7 +26,7 @@ watch(
     async () => {
         if (!gistRemote.value) return false;
         const identifier = gistRemote.value.identifier;
-        canPush.value = await accounts.findShareAccount(identifier);
+        canPush.value = accounts.findShareAccount(identifier);
     },
     { immediate: true },
 );
@@ -101,9 +101,7 @@ const share = () => {
 onMounted(() => {
     const identifier = gistRemote.value?.identifier;
     if (!identifier) return false;
-    accounts.findShareAccount(identifier).then((account) => {
-        canPush.value = account;
-    });
+    canPush.value = accounts.findShareAccount(identifier);
 });
 </script>
 
diff --git a/src/helpers/common.ts b/src/helpers/common.ts
index 7191b8d..81a9620 100644
--- a/src/helpers/common.ts
+++ b/src/helpers/common.ts
@@ -135,7 +135,7 @@ export const formatCurrentMatchTime = (match: Match, tournament: Tournament): st
 };
 
 export const copyToClipboard = (text: string) => {
-    navigator.clipboard.writeText(text);
+    void navigator.clipboard.writeText(text);
 };
 
 export const nextPowerOfTwo = (n: number): number => {
diff --git a/src/helpers/share/gist/gist.ts b/src/helpers/share/gist/gist.ts
index ad4ee35..92b1ee1 100644
--- a/src/helpers/share/gist/gist.ts
+++ b/src/helpers/share/gist/gist.ts
@@ -188,7 +188,7 @@ const accessTokenToAccount = async (accessToken: string) => {
     }
 };
 
-const isMine = async (identifier: string, accounts: Account[]) => {
+const isMine = (identifier: string, accounts: Account[]) => {
     try {
         const { author } = GistClient.fromShare(identifier);
         return accounts.find((x) => x.displayName === author) ?? null;
diff --git a/src/helpers/share/gist/pullSync.ts b/src/helpers/share/gist/pullSync.ts
index 4a0bedd..11fdd7d 100644
--- a/src/helpers/share/gist/pullSync.ts
+++ b/src/helpers/share/gist/pullSync.ts
@@ -72,7 +72,7 @@ export const createPullSync: PullSyncFactory<IGistPullSync> = (tournament) => {
                 date: new Date(),
             };
         },
-        async stop() {
+        stop() {
             console.log("[Gist] Stopping pull sync");
             if (this._timer) {
                 clearInterval(this._timer);
diff --git a/src/helpers/share/index.ts b/src/helpers/share/index.ts
index 9598507..ee1cbff 100644
--- a/src/helpers/share/index.ts
+++ b/src/helpers/share/index.ts
@@ -36,7 +36,7 @@ export interface IdentifierComponents {
     mode: ShareMode;
 }
 
-export type AccountResolver = (remote: IRemote) => Promise<Account | null>;
+export type AccountResolver = (remote: IRemote) => Account | null;
 
 export interface ISimpleShareClient {
     pull: (remote: IRemote) => Promise<Import | null>;
diff --git a/src/helpers/share/p2p/pullSync.ts b/src/helpers/share/p2p/pullSync.ts
index 6712860..e8a5b4d 100644
--- a/src/helpers/share/p2p/pullSync.ts
+++ b/src/helpers/share/p2p/pullSync.ts
@@ -100,7 +100,7 @@ const connectPullPeer = (context: PullContext) => {
 interface IP2PPullSync extends IPullSync {
     _peer: Peer;
     _connection: DataConnection | null;
-    _onDiff: (diff: Change[]) => Promise<void>;
+    _onDiff: (diff: Change[]) => void;
 }
 
 export const createPullSync: PullSyncFactory<IP2PPullSync> = (tournament) => {
@@ -112,7 +112,7 @@ export const createPullSync: PullSyncFactory<IP2PPullSync> = (tournament) => {
             type: "live",
             lastUpdate: new Date(),
         }),
-        async _onDiff(diff: Change[]) {
+        _onDiff(diff: Change[]) {
             if (!tournament.value) {
                 return;
             }
@@ -156,7 +156,7 @@ export const createPullSync: PullSyncFactory<IP2PPullSync> = (tournament) => {
                 }
             });
         },
-        async stop() {
+        stop() {
             console.log("[P2P] Stopping pull sync");
             this._connection?.close();
             this._connection = null;
diff --git a/src/helpers/share/p2p/pushSync.ts b/src/helpers/share/p2p/pushSync.ts
index bb1ace6..fc43fdc 100644
--- a/src/helpers/share/p2p/pushSync.ts
+++ b/src/helpers/share/p2p/pushSync.ts
@@ -76,12 +76,12 @@ const attachHostConnection =
     (connection: DataConnection) => {
         connections.push(connection);
 
-        connection.on("open", () => {
+        connection.on("open", async () => {
             if (!tournament.value) {
                 return;
             }
 
-            connection.send({
+            await connection.send({
                 type: "full",
                 data: deepCopy(toRaw(tournament.value)),
             });
@@ -209,9 +209,9 @@ export const createPushSync = (tournament: Ref<Tournament | null>): IPushSync =>
             return;
         }
 
-        connections.forEach((connection) => {
+        connections.forEach(async (connection) => {
             if (connection.open) {
-                connection.send({
+                await connection.send({
                     type: "diff",
                     data: changes,
                 });
diff --git a/src/pages/settings/general/appearance.vue b/src/pages/settings/general/appearance.vue
index 6125fe9..7287c8e 100644
--- a/src/pages/settings/general/appearance.vue
+++ b/src/pages/settings/general/appearance.vue
@@ -12,8 +12,11 @@ const theme = useThemeStore();
         >
             <div
                 class="theme-preview"
+                role="button"
+                tabindex="0"
                 :class="availableTheme"
                 @click="theme.set(availableTheme)"
+                @keydown.enter="theme.set(availableTheme)"
             ></div>
             <span class="theme-name">
                 {{ availableTheme }}
diff --git a/src/stores/persistence/indexedDb.ts b/src/stores/persistence/indexedDb.ts
index 989deb8..51efb76 100644
--- a/src/stores/persistence/indexedDb.ts
+++ b/src/stores/persistence/indexedDb.ts
@@ -1,7 +1,7 @@
 import localforage from "localforage";
 import type { ITournamentPersistor } from "./tournamentWatcher";
 import { tournamentFromJson } from "@/helpers";
-import type { AnyTournament, Tournament } from "@/types/tournament";
+import type { AnyTournament } from "@/types/tournament";
 import { toRaw } from "vue";
 
 const KEY_PREFIX = "tournament";
@@ -12,25 +12,27 @@ const store = localforage.createInstance({
 
 export const createIndexedDbStorage = (): ITournamentPersistor => {
     const key = (tournamentId: string) => `${KEY_PREFIX}.${tournamentId}`;
+    const getValue = async (key: string) => {
+        if (!key.startsWith(KEY_PREFIX)) return null;
+
+        const item = await store.getItem(key);
+        if (item) {
+            return tournamentFromJson(item as AnyTournament);
+        }
+        return null;
+    };
 
     return {
         load: async () => {
-            const storedTournaments: Tournament[] = [];
-            for (const key of await store.keys()) {
-                if (!key.startsWith(KEY_PREFIX)) continue;
-
-                const tournament = await store.getItem(key);
-                if (tournament) {
-                    storedTournaments.push(tournamentFromJson(tournament as AnyTournament));
-                }
-            }
-            return storedTournaments;
+            const keys = await store.keys();
+            const storedValues = await Promise.all(keys.map((k) => getValue(k)));
+            return storedValues.filter((v) => v != null);
         },
         onTournamentChange: (tournament) => {
-            store.setItem(key(tournament.id), toRaw(tournament));
+            void store.setItem(key(tournament.id), toRaw(tournament));
         },
         onTournamentDeleted: (tournament) => {
-            store.removeItem(key(tournament.id));
+            void store.removeItem(key(tournament.id));
         },
     };
 };
diff --git a/src/views/create/BasicsView.vue b/src/views/create/BasicsView.vue
index 1985bd7..b9e8844 100644
--- a/src/views/create/BasicsView.vue
+++ b/src/views/create/BasicsView.vue
@@ -72,8 +72,11 @@ const setSport = (sportKey: string) => {
                 v-for="(v, k) in DEFAULTS"
                 :key="k"
                 class="chip-option"
+                role="button"
+                tabindex="0"
                 :class="{ selected: tournament.config.sport === k }"
                 @click="setSport(k)"
+                @keydown.enter="setSport(k)"
                 :title="v.description"
             >
                 <ion-icon
diff --git a/src/views/create/TemplateView.vue b/src/views/create/TemplateView.vue
index 9d3f9ea..dab12ed 100644
--- a/src/views/create/TemplateView.vue
+++ b/src/views/create/TemplateView.vue
@@ -48,7 +48,10 @@ const useTemplate = (template: TournamentTemplate | null) => {
     <div class="template-list">
         <div
             class="template"
+            role="button"
+            tabindex="0"
             @click="useTemplate(null)"
+            @keydown.enter="useTemplate(null)"
         >
             <ion-icon
                 name="document-text-outline"
@@ -58,9 +61,12 @@ const useTemplate = (template: TournamentTemplate | null) => {
         </div>
         <div
             class="template"
+            role="button"
+            tabindex="0"
             v-for="template in templates"
             :key="template.name"
             @click="useTemplate(template)"
+            @keydown.enter="useTemplate(template)"
         >
             <img
                 :src="logoHref(template)"