[MEDIUM] TradingChart volume NaN/Infinity passed unchecked to lightweight-charts

[v1ktorrr0x]

Severity: Medium

Source

app/components/trade/TradingChart.tsx:741-755

Description

hasVolumeData only checks (c.volume ?? 0) > 0. If external candle data contains NaN or Infinity in the volume field (e.g., a corrupt API response), the value passes directly into volumeSeries.setData():

volumeSeries.setData(formatted.map((c) => ({
  time: c.time,
  value: c.volume ?? 0,  // NaN/Infinity passes through unchecked
  color: '...',
})));

Some versions of lightweight-charts throw synchronously when receiving NaN/Infinity data, crashing the React tree.

Fix

Add Number.isFinite guard:

value: Number.isFinite(c.volume) ? c.volume : 0,

[dcccrypto]

Fix ready in PR #2526 — triaged and implemented 2026-09-02.

hasVolumeData gated on (c.volume ?? 0) > 0. NaN was already excluded (NaN > 0 is false) — the live hole was Infinity, which is > 0, so one corrupt candle enabled the volume pane and handed Infinity to the histogram series, which then scales the whole pane off that value.

Now requires Number.isFinite first. Test covers both infinities, NaN, missing, the positive control, and a mixed array where one corrupt candle must not enable the pane.

[dcccrypto]

FIXED and merged to playground in PR #2527. Closing.

Verified on the merged branch (91dfff1a), not asserted from the diff. Launch suite: 3111 passed / 16 skipped / 0 failed.

the chart's volume pane now requires Number.isFinite(c.volume) before enabling — a NaN or Infinity no longer reaches the renderer.