Cannot use redis TLS certificates

[julien-pinchelimouroux]

Hello,

I was trying to use deadpool with a redis server which has tls enabled.
Currently, unlike the redis::ConnectionAddr, deadpool_redis::ConnectionAddr does not contain tls_params. That tls config is explicitly set to None in config.rs.

Moreover, there is currently no way to instantiate a Manager directly with a redis::Client, which could avoid that issue.

Is there a way to have a working pool with TLS that I miss ?

Regards

[bikeshedder]

You're right. The tls_params are currently not supported by the config structures deadpool-redis provides. That's indeed an oversight and I can't even remember setting that to None. 🙈

Would you like to provide a PR for that?

---

btw. passing a redis::Client is a great idea, too. That would allow for even more flexibility for users that really need it. The only downside is that the code gets a tad more complex and things like dynamic connection configs will be more difficult. If you wonder what I mean by that it's a feature planned for deadpool-postgres (See #402) which I also plan on adding to the other deadpool-* crates, too.

[julien-pinchelimouroux]

Hi @bikeshedder
Sorry for my late answer, I totally forgot to thank you and I wasn't available to solve this the passed few months.
I tried @rtimush proposal, i works for me so if its also ok for you, we can merge it and close this issue.
Regards,