In https://github.com/dedis/onet/blob/master/network/struct.go#L175, the ID of ServerIdentity depends on the output of Point.String(), which is bad, because String() is a method for users and is supposed to change.
Fix:
- easy: use
MarshalBinary and hex.EncodeToString
- better: add a
RfcMarshaller that is semantically stronger than a MarshalBinary
IMO, 1. is enough, as for me MarshalBinary shouldn't change. But see discussion in #405
In https://github.com/dedis/onet/blob/master/network/struct.go#L175, the
IDofServerIdentitydepends on the output ofPoint.String(), which is bad, becauseString()is a method for users and is supposed to change.Fix:
MarshalBinaryandhex.EncodeToStringRfcMarshallerthat is semantically stronger than aMarshalBinaryIMO, 1. is enough, as for me
MarshalBinaryshouldn't change. But see discussion in #405