From d4dc703715faca88c2f0b9b1bfbc37a1c736c912 Mon Sep 17 00:00:00 2001 From: DJ Majumdar Date: Sat, 21 Mar 2026 19:37:20 -0700 Subject: [PATCH] fix: use distinct critcmp group names for PR benchmark comparison The baseline and PR benchmarks were both exported under the group name "current", causing critcmp to merge them into a single column instead of producing a side-by-side comparison with ratios. --- .github/workflows/benchmarks.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 60a21f9..c2b8a3c 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -90,9 +90,12 @@ jobs: echo "::warning::No benchmark baseline found. Merge to main to generate one." exit 0 fi + # Import the cached baseline under the name "main" so critcmp + # can distinguish the two groups and produce a side-by-side comparison. + critcmp --import baseline.json --name main critcmp --export current > pr.json echo 'result<> $GITHUB_OUTPUT - critcmp baseline.json pr.json >> $GITHUB_OUTPUT + critcmp main current >> $GITHUB_OUTPUT echo 'EOF' >> $GITHUB_OUTPUT - name: Find existing comment