From 22b3a1792c9771434155b9a1fd5f1c86d892ff1e Mon Sep 17 00:00:00 2001 From: morluto <76467478+morluto@users.noreply.github.com> Date: Sat, 11 Jul 2026 04:07:23 +0000 Subject: [PATCH] Avoid duplicate final checkpoint save --- deepspec/trainer/base_trainer.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/deepspec/trainer/base_trainer.py b/deepspec/trainer/base_trainer.py index d5b7c618..b09a92f6 100644 --- a/deepspec/trainer/base_trainer.py +++ b/deepspec/trainer/base_trainer.py @@ -358,6 +358,7 @@ def train(self): return local_batch_size = int(self.args.train.local_batch_size) + checkpointing_steps = int(self.args.logging.checkpointing_steps) total_micro_steps = self.max_train_steps * self.gradient_accumulation_steps remaining_micro_steps = total_micro_steps - self.next_micro_step remaining_samples = remaining_micro_steps * local_batch_size @@ -397,14 +398,15 @@ def train(self): grad_norm=grad_norm.item(), ) - if self.global_step % int(self.args.logging.checkpointing_steps) == 0: + if self.global_step % checkpointing_steps == 0: self.save_and_eval_checkpoint() if self.suspend_controller.requested(): self._save_and_suspend() return - self.save_and_eval_checkpoint() + if self.global_step % checkpointing_steps != 0: + self.save_and_eval_checkpoint() def clean_up(self): training_logger.close()