From ca227895d224dcccdbf3217328a0c9889b377bbd Mon Sep 17 00:00:00 2001 From: Jordan Overbye Date: Fri, 11 Feb 2022 10:34:30 +1000 Subject: [PATCH 1/2] Add rfc --- RFC-by-stage/1-approved/rename-form-group.md | 21 ++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 RFC-by-stage/1-approved/rename-form-group.md diff --git a/RFC-by-stage/1-approved/rename-form-group.md b/RFC-by-stage/1-approved/rename-form-group.md new file mode 100644 index 0000000..beb244b --- /dev/null +++ b/RFC-by-stage/1-approved/rename-form-group.md @@ -0,0 +1,21 @@ +--- +Status: `Proposal` # Please do not change this. +Implementer: # It will be changed upon merging and as it moves through the RFC stages +--- + +# Rename form group + +## The issue to be solved + +Currenty GOLD uses the name `form group` to refer to the elements which make up a single form field (label, hint, error message etc). I believe the naming could be improved as it can be easily mistaken for a collection of form fields and not a single form field. + +## A short description of the desired outcome or solution + +- (The documentation)[https://gold.designsystemau.org/components/form/#form-groups] is updated to reflect the new name +- `au-form-group` is renamed to `au-field`. + +## Technical details + +- Rename CSS class +- No JS changes are necessary +- Update documentation \ No newline at end of file From 5e162aee45d5705825ce51309a9a585ab1598ace Mon Sep 17 00:00:00 2001 From: Jordan Overbye <6265154+jordanoverbye@users.noreply.github.com> Date: Fri, 11 Feb 2022 10:35:59 +1000 Subject: [PATCH 2/2] Fix typo --- RFC-by-stage/1-approved/rename-form-group.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RFC-by-stage/1-approved/rename-form-group.md b/RFC-by-stage/1-approved/rename-form-group.md index beb244b..770d2e2 100644 --- a/RFC-by-stage/1-approved/rename-form-group.md +++ b/RFC-by-stage/1-approved/rename-form-group.md @@ -7,7 +7,7 @@ Implementer: # It will be changed upon merging and as it moves through the RFC s ## The issue to be solved -Currenty GOLD uses the name `form group` to refer to the elements which make up a single form field (label, hint, error message etc). I believe the naming could be improved as it can be easily mistaken for a collection of form fields and not a single form field. +Currently GOLD uses the name `form group` to refer to the elements which make up a single form field (label, hint, error message etc). I believe the naming could be improved as it can be easily mistaken for a collection of form fields and not a single form field. ## A short description of the desired outcome or solution