-
Notifications
You must be signed in to change notification settings - Fork 37
7.8 - The demo seed scripts cannot run, and only know testnet #161
Copy link
Copy link
Closed
Labels
Stellar WaveDrips Wave Program - opt an issue in by applying this labelDrips Wave Program - opt an issue in by applying this labelarea:distributionnpm packages, docs, grant framing, demo assetsnpm packages, docs, grant framing, demo assetscomplexity:trivial100 points100 pointsgood-first-issueSelf-contained, well-scoped, safe for newcomersSelf-contained, well-scoped, safe for newcomerstype:dx
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
Stellar WaveDrips Wave Program - opt an issue in by applying this labelDrips Wave Program - opt an issue in by applying this labelarea:distributionnpm packages, docs, grant framing, demo assetsnpm packages, docs, grant framing, demo assetscomplexity:trivial100 points100 pointsgood-first-issueSelf-contained, well-scoped, safe for newcomersSelf-contained, well-scoped, safe for newcomerstype:dx
Complexity: Trivial - 100 Points ·
type:dxMilestone: M5 - Distribution & grant
Band lever: none
Context
scripts/demo-seed.tsandscripts/demo-reset.tsback thepnpm demo:seedworkflow that the README and the demo page depend on.
Problem
Two things stop them being useful. They cannot resolve
@stellar/stellar-sdkfrom the repo root under pnpm's strict
node_moduleslayout, sopnpm demo:seedfails outright. And they hardcode
Networks.TESTNETand friendbot, so even whenfixed they cannot seed a mainnet or self-hosted deployment.
What needs to be done
apps/api/scripts/(asgen-mainnet-secrets.mjsalready was), or add the SDK to the root manifest —the first is preferred, it keeps the root manifest thin.
to testnet, instead of hardcoding.
message rather than failing obscurely.
Key files
scripts/demo-seed.ts,scripts/demo-reset.tspackage.json— thedemo:seed/demo:resetscriptsapps/api/src/env.ts— the network/Horizon variables to reuseDone when
pnpm demo:seedsucceeds from a clean install.Tracked in
ISSUES.md— issue 7.8.