Make notifier chain resilient to webhook failures
--
Context
When my webhook endpoint hiccups, prw stops before printing the console notification, so I miss local updates entirely.
Repro
- Configure a webhook to a local server, then shut it down
- Run
prw run and trigger a notification; console output should still print
Problem
MultiNotifier.Notify returns on the first notifier error and short-circuits the rest. A failing webhook blocks the console notifier.
Expected behavior
Console output should always show up even if a webhook fails; errors are reported after all notifiers are attempted.
Scope / non-goals
- Don’t redesign notifier types or add new transports.
- Keep logging concise; no retry logic here.
Acceptance criteria
Hints
internal/notify/notify.go holds MultiNotifier; add tests nearby. This is a friendly good-first-issue.
Make notifier chain resilient to webhook failures
--
Context
When my webhook endpoint hiccups,
prwstops before printing the console notification, so I miss local updates entirely.Repro
prw runand trigger a notification; console output should still printProblem
MultiNotifier.Notifyreturns on the first notifier error and short-circuits the rest. A failing webhook blocks the console notifier.Expected behavior
Console output should always show up even if a webhook fails; errors are reported after all notifiers are attempted.
Scope / non-goals
Acceptance criteria
MultiNotifierruns all notifiers without short-circuiting; console executes first.Hints
internal/notify/notify.goholdsMultiNotifier; add tests nearby. This is a friendly good-first-issue.