Skip to content

Grading PR#44

Open
martypdx wants to merge 3 commits into
devfolio:developmentfrom
martypdx:development
Open

Grading PR#44
martypdx wants to merge 3 commits into
devfolio:developmentfrom
martypdx:development

Conversation

@martypdx

Copy link
Copy Markdown

specific comments in code, general comments here:

server

  • Missing basic golden-path http tests
  • Only two individual routes are protected, seems like should be more
  • putting the routes under an oauth folder, but then having those handle general selection details in confusing. Better to pick a broader term like "sources", "integrations", or something like that

app

  • No tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant