MockSequence doesn't ensure all calls in sequence were executed

[jez9999]

Describe the Bug

I'm testing that a helper I wrote calls a lambda with specific arguments in a specific order, which is what MockSequence is supposed to enforce. However, I don't get an exception if I add Setup steps to the sequence that are not called. I want that to be flagged as a failure.

Steps to Reproduce

	[Test]
	public void Move_B_C_H_before_F_in_given_order() {
		var input = new List<char> { 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H' };

		var mock = new Mock<Action<int, int>>(MockBehavior.Strict);
		var seq = new MockSequence();
		mock.InSequence(seq).Setup(x => x(7, 5));
		mock.InSequence(seq).Setup(x => x(1, 5));
		mock.InSequence(seq).Setup(x => x(1, 5));
		mock.InSequence(seq).Setup(x => x(2, 5));

		ReorderingHelper.ReorderPages(
			[7, 1, 2],
			5,
			mock.Object,
			orderSelectedIndicesAscending: false
		);

		// ^ passes, but was not called with 2,5!
	}

Expected Behavior

The test should fail unless all specified setups in the sequence were called.

[GillesTourreau]

@jez9999,

We should use the VerifyAll() method at the end of the unit test to check that all the Setup() has been invoked.
With the InSequence() it seam to have a bug with Moq and it do not check it...

The alternative is to explictly call the Verify() method for each method mocked :

[Fact]
public void Move_B_C_H_before_F_in_given_order()
{
    var input = new List<char> { 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H' };

    var mock = new Mock<Action<int, int>>(MockBehavior.Strict);
    var seq = new MockSequence();
    mock.InSequence(seq).Setup(x => x(7, 5));
    mock.InSequence(seq).Setup(x => x(1, 5));
    mock.InSequence(seq).Setup(x => x(1, 5));
    mock.InSequence(seq).Setup(x => x(2, 5));

    mock.Object(7, 5);
    mock.Object(1, 5);
    mock.Object(1, 5);

    mock.Verify(x => x(7, 5));
    mock.Verify(x => x(1, 5), Times.Exactly(2));
    mock.Verify(x => x(2, 5));
}