diff --git a/DiffPalReviewDevV1/task.json b/DiffPalReviewDevV1/task.json index 8cdbde2..37a5ec5 100644 --- a/DiffPalReviewDevV1/task.json +++ b/DiffPalReviewDevV1/task.json @@ -109,26 +109,17 @@ "defaultValue": "false", "helpMarkDown": "Pass --debug to DiffPal so provider and runtime diagnostics are printed." }, - { - "name": "mode", - "type": "string", - "label": "Publish modes", - "required": false, - "defaultValue": "", - "helpMarkDown": "Advanced comma-separated Azure DevOps publish modes. Overrides feedback when set." - }, { "name": "feedback", "type": "pickList", "label": "Feedback", "required": false, - "defaultValue": "balanced", + "defaultValue": "review", "options": { "summary": "Summary", - "balanced": "Balanced", - "inline": "Inline" + "review": "Review" }, - "helpMarkDown": "Review feedback shape. Summary posts status and one PR summary. Balanced and Inline publish Azure threads for all findings; blocking findings stay active and non-blocking findings are closed immediately." + "helpMarkDown": "Review feedback shape. Summary posts status and one PR summary. Review publishes Azure threads for findings; blocking findings stay active and non-blocking findings are closed immediately." }, { "name": "language", diff --git a/DiffPalReviewV1/task.json b/DiffPalReviewV1/task.json index e0d7c15..5668fc5 100644 --- a/DiffPalReviewV1/task.json +++ b/DiffPalReviewV1/task.json @@ -109,26 +109,17 @@ "defaultValue": "false", "helpMarkDown": "Pass --debug to DiffPal so provider and runtime diagnostics are printed." }, - { - "name": "mode", - "type": "string", - "label": "Publish modes", - "required": false, - "defaultValue": "", - "helpMarkDown": "Advanced comma-separated Azure DevOps publish modes. Overrides feedback when set." - }, { "name": "feedback", "type": "pickList", "label": "Feedback", "required": false, - "defaultValue": "balanced", + "defaultValue": "review", "options": { "summary": "Summary", - "balanced": "Balanced", - "inline": "Inline" + "review": "Review" }, - "helpMarkDown": "Review feedback shape. Summary posts status and one PR summary. Balanced and Inline publish Azure threads for all findings; blocking findings stay active and non-blocking findings are closed immediately." + "helpMarkDown": "Review feedback shape. Summary posts status and one PR summary. Review publishes Azure threads for findings; blocking findings stay active and non-blocking findings are closed immediately." }, { "name": "language", diff --git a/README.md b/README.md index f32503e..ecbec4b 100644 --- a/README.md +++ b/README.md @@ -41,7 +41,7 @@ base/head, and redacted CLI arguments before the review starts. Set `debug: true` to pass `--debug` to DiffPal and enable provider/runtime diagnostics. This is separate from Azure `System.Debug`. -With `feedback: balanced` or `feedback: inline`, DiffPal publishes Azure threads +With `feedback: review`, DiffPal publishes Azure threads for all findings. Blocking findings stay active; non-blocking findings are published as closed immediately. Findings without canonical file/line mapping to current PR changes are skipped instead of publishing a broken file thread. @@ -72,7 +72,7 @@ steps: inputs: diffpalVersion: 0.1.35 profile: ci - feedback: balanced + feedback: review env: OPENAI_API_KEY: $(OPENAI_API_KEY) SYSTEM_ACCESSTOKEN: $(System.AccessToken) @@ -95,7 +95,7 @@ steps: displayName: DiffPal blocking review inputs: profile: ci - feedback: balanced + feedback: review gate: true blockOn: high env: @@ -121,7 +121,7 @@ steps: displayName: DiffPal review with Copilot inputs: profile: ci - feedback: balanced + feedback: review env: GITHUB_TOKEN: $(GITHUB_TOKEN) SYSTEM_ACCESSTOKEN: $(System.AccessToken) diff --git a/overview.md b/overview.md index c2bdde6..e75381b 100644 --- a/overview.md +++ b/overview.md @@ -14,7 +14,7 @@ steps: - task: DiffPalReview@1 inputs: profile: ci - feedback: balanced + feedback: review gate: true env: SYSTEM_ACCESSTOKEN: $(System.AccessToken) diff --git a/scripts/smoke-test.js b/scripts/smoke-test.js index 42d6695..dca8bf5 100644 --- a/scripts/smoke-test.js +++ b/scripts/smoke-test.js @@ -25,7 +25,7 @@ function runHandler(name, env) { INPUT_BASE: "base-sha", INPUT_HEAD: "head-sha", INPUT_BLOCKON: "high", - INPUT_FEEDBACK: "balanced", + INPUT_FEEDBACK: "review", SYSTEM_ACCESSTOKEN: "system-token", ...env }, @@ -47,7 +47,7 @@ function runHandlerExpectFailure(name, env) { INPUT_BASE: "base-sha", INPUT_HEAD: "head-sha", INPUT_BLOCKON: "high", - INPUT_FEEDBACK: "balanced", + INPUT_FEEDBACK: "review", SYSTEM_ACCESSTOKEN: "system-token", ...env }, @@ -510,7 +510,7 @@ function testExplainPrintsResolvedContext() { INPUT_BASE: "", INPUT_HEAD: "", INPUT_BLOCKON: "high", - INPUT_FEEDBACK: "balanced", + INPUT_FEEDBACK: "review", INPUT_EXPLAIN: "true", SYSTEM_ACCESSTOKEN: "secret-token-value", SYSTEM_PULLREQUEST_PULLREQUESTID: "123", diff --git a/src/index.ts b/src/index.ts index 74b7000..a1926a4 100644 --- a/src/index.ts +++ b/src/index.ts @@ -478,11 +478,7 @@ async function run(): Promise { if (gate) { args.push("--gate"); } - const mode = input("mode"); - addOptional(args, "--mode", mode); - if (!mode) { - addOptional(args, "--feedback", input("feedback") || "balanced"); - } + addOptional(args, "--feedback", input("feedback") || "review"); addOptional(args, "--language", input("language")); addOptional(args, "--instructions", input("instructions")); addOptional(args, "--instructions-file", resolveInstructionsFile(input("instructionsFile")));