[Bug] The `vdu_controls-2.6.5-11.1.noarch.rpm` for `Fedora_37` fails to invoke on `fedora:44`.

[RokeJulianLockhart]

Context

I want to confirm that issues/44#issuecomment-4403135368 works on my Framework 16, and I want to ensure that issues/97#issuecomment-2436316104 remains applicable, so that I can report it.

The Problem

However, it fails to invoke:

1. #!/usr/bin/env sh
   run0 dnf5 install --refresh -y https://ftp.gwdg.de/pub/opensuse/repositories/home%3A/mchnz/Fedora_37/noarch/vdu_controls-2.6.5-11.1.noarch.rpm && \
   vdu_controls

   ¹

2. Trying Qt6
   14:05:52 INFO: Looking for config file '/home/RokeJulianLockhart/.config/vdu_controls/vdu_controls.conf'
   14:05:52 WARNING: ('vdu-controls-globals', 'smart-window'): Wayland disallows app window placement. Switching to XWayland.
   14:05:52 INFO: Forcing Xwayland, setting environment variable QT_QPA_PLATFORM=xcb
   14:05:52 INFO: app.applicationName()='vdu_controls' QApplication.instance().applicationName()='vdu_controls'
   14:05:52 INFO: VDU Controls 2.6.5 /usr/bin/vdu_controls  
   14:05:52 INFO: python-locale: ('en_GB', 'UTF-8') Qt-locale: en_GB
   14:05:52 INFO: desktop: KDE; session-type: wayland; platform: xcb; Qt: 6.10.3
   14:05:52 INFO: app-style: breeze (detected a light theme)
   14:05:52 INFO: Logging to stdout
   14:05:52 INFO: logging: logging to syslog is enabled
   14:05:52 WARNING: logging: debug is enabled
   14:05:52 INFO: Started with dark theme: False
   14:05:52 ERROR: shortcut_letter='C' already in in self.reserved_shortcuts=['C', 'P', 'G', 'A']
   14:05:52 INFO: native_font_height_pixels=18
   14:05:53 INFO: splash_message: 'Looking for DDC monitors...'
   14:05:53 INFO: Configuring application (reconfiguring=False)...
   14:05:53 INFO: logging: logging to syslog is enabled
   14:05:53 INFO: Remotely configuring ddcutil-service ServiceEmitSignals=True
   14:05:53 ERROR: Sanity check try 1: com.ddcutil.DdcutilInterface failed: The name is not activatable
   14:05:53 INFO: looping
   14:05:53 ERROR: 
   Traceback (most recent call last):
     File "<frozen runpy>", line 198, in _run_module_as_main
     File "<frozen runpy>", line 88, in _run_code
     File "/usr/bin/vdu_controls/__main__.py", line 3, in <module>
       vdu_controls_main.main()
       ~~~~~~~~~~~~~~~~~~~~~~^^
     File "/usr/bin/vdu_controls/vdu_controls_main.py", line 8, in main
       application.main()
       ~~~~~~~~~~~~~~~~^^
     File "/usr/bin/vdu_controls/vdu_controls/vdu_controls_application.py", line 1568, in main
       VduAppWindow(main_config, main_controller)  # may need to assign this to a variable to prevent garbage collection?
       ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/bin/vdu_controls/vdu_controls/vdu_controls_application.py", line 1098, in __init__
       self.main_controller.configure_application(self)
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
     File "/usr/bin/vdu_controls/vdu_controls/vdu_controls_application.py", line 347, in configure_application
       self.create_ddcutil()
       ~~~~~~~~~~~~~~~~~~~^^
     File "/usr/bin/vdu_controls/vdu_controls/vdu_controls_application.py", line 397, in create_ddcutil
       self.ddcutil = DdcutilAggregator(common_args=self.main_config.get_ddcutil_extra_args(),
                      ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                        prefer_dbus_client=self.main_config.is_set(ConfOpt.DBUS_CLIENT_ENABLED),
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                        connected_vdus_changed_callback=change_handler)
                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/bin/vdu_controls/vdu_controls/ddcutil_aggregator.py", line 38, in __init__
       self.ddcutil_impl = DdcutilDBusImpl(self.common_args, callback=connected_vdus_changed_callback)
                           ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/usr/bin/vdu_controls/vdu_controls/ddcutil_qdbus.py", line 67, in __init__
       time.sleep(2)  # Try again
       ^^^^^^^^^^
   AttributeError: type object 'datetime.time' has no attribute 'sleep'

My Environment

1. Details

   #!/usr/bin/env sh
   cat /etc/os-release | jc --ini | jq 'with_entries(.value |= (if type=="string" and test("^[0-9]+$") then tonumber else . end))| {VARIANT, NAME, VERSION_ID}' | yq -P

2. VARIANT: KDE Plasma Desktop Edition
   NAME: Fedora Linux
   VERSION_ID: 44

Footnotes

1. build.opensuse.org/package/show/home:mchnz/vdu_controls#comment-2264974 ↩

[digitaltrails]

During refactoring some imports were accidentally changed from import time to from datetime import time, the two times are quite different.

Python time is mainly used for sleeping when errors occur. In your detect, it must have had an error and was trying again, so the sleep path got invoked. I think I fixed all of these.

It's a bit of a python wart, I may eventually change to import time as py_time - perhaps that would make accidents less likely.

[digitaltrails]

I've refactored the application into multiple source files. I build it as a python zipapp to bundle it all back into one file. I'm using the OpenSUSE Build Service to test the changes to packaging.

So the 2.6.5 available via the Build Service is a bit beta. That said, the work is mostly complete, I'm happily using it as my daily-driver, but I need to test more execution paths.