REDMINE_DB_PORT not used

[MartinOpitz274]

In /docker-entrypoint.sh, the variable REDMINE_DB_PORT is ignored and a hard-coded value 3306 is used:
file_env 'REDMINE_DB_PORT' '3306'
This is completely unflexible when using several redmine instances concurrently

[tianon]

redmine/docker-entrypoint.sh

Lines 5 to 25 in eb65a44

	# usage: file_env VAR [DEFAULT]
	# ie: file_env 'XYZ_DB_PASSWORD' 'example'
	# (will allow for "$XYZ_DB_PASSWORD_FILE" to fill in the value of
	# "$XYZ_DB_PASSWORD" from a file, especially for Docker's secrets feature)
	file_env() {
	local var="$1"
	local fileVar="${var}_FILE"
	local def="${2:-}"
	if [ "${!var:-}" ] && [ "${!fileVar:-}" ]; then
	echo >&2 "error: both $var and $fileVar are set (but are exclusive)"
	exit 1
	fi
	local val="$def"
	if [ "${!var:-}" ]; then
	val="${!var}"
	elif [ "${!fileVar:-}" ]; then
	val="$(< "${!fileVar}")"
	fi
	export "$var"="$val"
	unset "$fileVar"
	}

[MartinOpitz274]

My problem is the statement:
file_env 'REDMINE_DB_PORT' '3306'
This should be:
**file_env 'REDMINE_DB_PORT' "${MYSQL_ENV_MYSQL_PORT:-3306}"

[tianon]

Please re-read the file_env implementation -- the lines you're looking for are specifically here:

redmine/docker-entrypoint.sh

Lines 17 to 19 in eb65a44

	local val="$def"
	if [ "${!var:-}" ]; then
	val="${!var}"

To illustrate, I've put file_env into a separate file so I can demonstrate that this works correctly in an interactive shell:

$ source file-env.sh

$ ( file_env 'FOO' 'default'; echo "$FOO" )
default

$ ( export FOO=bar; file_env 'FOO' 'default'; echo "$FOO" )
bar