Skip to content

Product version has commit hash appended in source-build but not in MSFT build #1611

@mthalman

Description

@mthalman

Microsoft.Css.Parser.dll has a product version that includes no commit hash metadata in the MSFT build, but source-build appends the VMR commit hash:

  • MSFT: 1.0.0-20230414.1
  • SB: 1.0.0-20230414.1+0f576f0a937886996ec6b606fbe9a0c37b5884b3

The source-build project cssparser.proj passes /p:VersionSuffix=$(CssParserReleaseVersionSuffix) but does not set IncludeSourceRevisionInInformationalVersion=false or explicitly set InformationalVersion. Because SourceLink is active in the VMR build environment, the SDK's AddSourceRevisionToInformationalVersion target appends +<VMR commit hash> to the InformationalVersion. The MSFT build of this package either has SourceLink disabled or IncludeSourceRevisionInInformationalVersion set to false, so no hash is appended.

Affected DLLs

  • sdk/x.y.z/Sdks/Microsoft.NET.Sdk.Razor/tools/Microsoft.Css.Parser.dll
  • sdk/x.y.z/Sdks/Microsoft.NET.Sdk.StaticWebAssets/tasks/netx.y/Microsoft.Css.Parser.dll

Proposed Solution

Add /p:IncludeSourceRevisionInInformationalVersion=false to cssparser.proj to prevent the SDK from appending the VMR commit hash to InformationalVersion. This matches the MSFT build behavior where no hash is present.

Metadata

Metadata

Labels

area-buildRelated to builds (developer, CI and PR validation)untriagedNeeds to be triaged

Type

No type
No fields configured for issues without a type.

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions