[TESTING]: Increase test coverage

[drkrillo]

Problem

There have been functions added to the api_handler classes, and now the test coverage is no longer 100 %.

Solution

• Add test cases for the functions that don't have it.
• Solve test cases that are now failing.
• Remove unnecesary information from the TESTING.md file, and update as necessary.

Important note

You don't need to solve all the issue:

• You can add just one test case that passses, or
• Modifty a test that is not passing, or
• Modifty the TESTING.md

Just let me know in the comments what are you going to fix, and if you need any further guidance.

[Prerana-Sodankoor]

Hi! I'd like to work on this issue. My plan is to update the TESTING.md to reflect current coverage, fix any failing tests, and add missing test cases for new functions. Please let me know if this is still available.

[drkrillo]

hi @Prerana-Sodankoor !

This is a repo intended to help people onboard on open source. It doesn't really matter if you know a lot of English or not to contribute. I am trying to help real human beings onboard and learn through the process.

Unfortunately, recieving 3 almost simultaneous messages on the issues with the same structure and paraphrasing what the issue body already said, makes me believe that you are farming contributions, without caring much about what the repo is about.

If you are still interested in solving a particular issue, choose one, and try to use your own words to explain it. There is no problem at all with not having the perfect answer right ahead, we can discuss it together and find the best solution.

what do you think?

[Prerana-Sodankoor]

hi @drkrillo , Sorry for the spam, I'll focus on #91 only!

[keerthanasathish985-beep]

Hi @drkrillo! I’d like to work on adding a test case for one of the functions that currently doesn’t have tests yet. I’m still getting familiar with the project, so I’ll start with a smaller part first.

[drkrillo]

Hi @keerthanasathish985-beep !!

Yes, no problem at all. If you need anything from my side, just let me know.

Once you have something to test, open a PR so I can take a look, if you want.

Happy to have you around! Thanks for contributing :)

[drkrillo]

Hi @keerthanasathish985-beep !

Some useful info:

1. pytest-cov is not installed, so the command in TESTING.md (python -m pytest app/tests/ -v --cov=app) doesn't work. It needs to be added to requirements.txt. > To test it right now, use python -m pytest app/tests/ -v
2. The mock_env_vars fixture is missing from conftest.py. That makes 4 tests fail in test_update_issues.py before they even start.
3. The test test_extract_issue_data is outdated: the function now returns labels and state fields, but the test doesn't check for them since it wasn't updated when the change was done.

I think any of these three options are good starters. I would go with 1 in combination with 2 or 3, but it's up to you. What do you think?

[nilesh-rajpurohit]

Hi @drkrillo! I'd like to work on this. My plan is to add the mock_env_vars fixture to conftest.py to fix the 4 failing tests, and update test_extract_issue_data to check for the labels and state fields. Let me know if this is still available

[drkrillo]

Hi @nilesh-rajpurohit !

Sounds good. It's still available so go ahead. Consider adding pytest-cov to the requirements (see my comment above point 1). Thanks for contributinhg!