Say hello to Diya, our newest contributor! #250
collinsezedike
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
This week's focus was contributor experience and a handful of reliability fixes.
CONTRIBUTING rewrite and PR template (#231)
CONTRIBUTING.md has been fully rewritten. It now covers environment setup, the branching model, how to write a good PR, and what to expect during review. A PR template is also in place so new contributors know exactly what to include when opening a pull request.
Smarter retry logic (#239, #241)
withRetrynow accepts ashouldRetrypredicate. Timeout errors skip retries by default instead of hammering an already-timed-out RPC node. The timer leak inwithSorobanTimeoutandwithBlendTimeoutis also fixed. Timeout handles are now cleared on both the success and failure paths, not just on timeout.DeFindex error handling (#243, #244, #245)
DeFindex errors in
resolvePositionsnow propagate to the caller instead of being swallowed silently and returning partial data as a 200. The DeFindex RPC timeout is also raised above the outer race timeout so the inner timeout fires first and produces a readable error. The vault ID is now read fromProtocolAddressesinstead of being hardcoded.HTTP-layer tests (#246)
All Fastify routes now have test coverage using
fastify.inject(). Tests run against the full request/response cycle without a live RPC connection.Really grateful to @Diyaaa-12 for clearing the TypeScript errors that had been sitting in the web app (#240).
Back to building.
— Collins
All reactions