Skip to content

[Docs] signing-flow.md claims a 503 status deposit/withdraw never actually return #661

Description

@collinsezedike

Description

docs/signing-flow.md:106-110 ("Error responses") states both /tx/deposit and /tx/withdraw return "400 ... 503 if the vault contract is not configured, and 500 ... otherwise."

packages/api-core/src/tx.ts's handleDepositRequest/handleWithdrawRequest wrap the whole build call in a single try/catch that always returns status: 500 on any thrown error, including when resolveVaultEntry (packages/stellar-sdk-helpers/src/orchestration.ts:19-23) throws for an unconfigured vault. There is no 503 path anywhere in these two handlers — 503 is only used elsewhere, in packages/api-core/src/positions.ts:19, for a different endpoint.

Expected Behavior

The error-responses table in docs/signing-flow.md should state that an unconfigured vault on /tx/deposit//tx/withdraw returns 500, not 503.

Actual Behavior

The doc claims a 503 path that doesn't exist for these two endpoints.

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programdocsDocumentation, guides, README, inline docs, or ADRstrivialSelf-contained task, completable in < 2 hours with no deep protocol knowledge required

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions