From fa7f6f800315236c57edf0fea0212a95396e810a Mon Sep 17 00:00:00 2001 From: funmilayo-ui <316746874+funmilayo-ui@users.noreply.github.com> Date: Mon, 31 Aug 2026 06:56:26 +0100 Subject: [PATCH] docs: correct deposit/withdraw error statuses in signing-flow /tx/deposit and /tx/withdraw have no 503 path: both handlers wrap the build call in one try/catch that returns 500, unconfigured vault included. 503 is only used by the positions endpoint. --- docs/signing-flow.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/signing-flow.md b/docs/signing-flow.md index df49ed7d..5712c931 100644 --- a/docs/signing-flow.md +++ b/docs/signing-flow.md @@ -106,8 +106,13 @@ Response `200`: same shape as deposit — `{ "xdr": "...", "fee": "..." }`. ### Error responses Both endpoints return `400` with `{ "error": "" }` for validation failures -(bad public key, malformed amount, missing fields), `503` if the vault contract is not -configured, and `500` with the simulation/build error message otherwise. +(bad public key, malformed amount, missing fields), and `500` with the +simulation/build error message for anything else that throws — including a vault whose +contract address is not configured, which surfaces as +`Vault not configured: . Add it to KNOWN_POOLS with a contractId.` +There is no `503` on these two endpoints: `handleDepositRequest`/`handleWithdrawRequest` +in [`packages/api-core/src/tx.ts`](../packages/api-core/src/tx.ts) wrap the whole build +call in one `try/catch` that always answers `500`. ## What the frontend must do between receiving the XDR and submitting