From c812e774ddeecc43c30531e254d2c125f4bc24f0 Mon Sep 17 00:00:00 2001
From: Otfrugger <iupacnumen2020@gmail.com>
Date: Mon, 31 Aug 2026 12:03:37 +0100
Subject: [PATCH] fix(web): disable deposit and withdraw submit on zero or
 negative amounts

---
 .../src/__tests__/components/DepositTab.test.tsx | 16 ++++++++++++++++
 .../__tests__/components/WithdrawTab.test.tsx    | 16 ++++++++++++++++
 apps/web/src/components/dashboard/DepositTab.tsx |  8 +++++++-
 .../web/src/components/dashboard/WithdrawTab.tsx |  2 ++
 4 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/apps/web/src/__tests__/components/DepositTab.test.tsx b/apps/web/src/__tests__/components/DepositTab.test.tsx
index 89fb4251..74437e14 100644
--- a/apps/web/src/__tests__/components/DepositTab.test.tsx
+++ b/apps/web/src/__tests__/components/DepositTab.test.tsx
@@ -64,6 +64,22 @@ describe("DepositTab", () => {
     expect(onSubmit).toHaveBeenCalledTimes(1);
   });
 
+  it("disables the submit button when amount is zero", () => {
+    renderDepositTab({ amount: "0" });
+    expect(screen.getByTestId("vault-deposit-submit")).toHaveProperty(
+      "disabled",
+      true
+    );
+  });
+
+  it("disables the submit button when amount is negative", () => {
+    renderDepositTab({ amount: "-1" });
+    expect(screen.getByTestId("vault-deposit-submit")).toHaveProperty(
+      "disabled",
+      true
+    );
+  });
+
   it("disables the submit button when amount is empty", () => {
     renderDepositTab({ amount: "" });
 
diff --git a/apps/web/src/__tests__/components/WithdrawTab.test.tsx b/apps/web/src/__tests__/components/WithdrawTab.test.tsx
index c3604199..ec660448 100644
--- a/apps/web/src/__tests__/components/WithdrawTab.test.tsx
+++ b/apps/web/src/__tests__/components/WithdrawTab.test.tsx
@@ -79,6 +79,22 @@ describe("WithdrawTab", () => {
     expect(onSubmit).toHaveBeenCalledTimes(1);
   });
 
+  it("disables the submit button when amount is zero", () => {
+    renderWithdrawTab({ amount: "0" });
+    expect(screen.getByTestId("vault-withdraw-submit")).toHaveProperty(
+      "disabled",
+      true
+    );
+  });
+
+  it("disables the submit button when amount is negative", () => {
+    renderWithdrawTab({ amount: "-1" });
+    expect(screen.getByTestId("vault-withdraw-submit")).toHaveProperty(
+      "disabled",
+      true
+    );
+  });
+
   it("disables the submit button when amount exceeds available shares", () => {
     renderWithdrawTab({ amount: "999" });
 
diff --git a/apps/web/src/components/dashboard/DepositTab.tsx b/apps/web/src/components/dashboard/DepositTab.tsx
index 6da1f0ed..7d909f3c 100644
--- a/apps/web/src/components/dashboard/DepositTab.tsx
+++ b/apps/web/src/components/dashboard/DepositTab.tsx
@@ -58,7 +58,13 @@ export function DepositTab({
       <button
         data-testid="vault-deposit-submit"
         onClick={onSubmit}
-        disabled={!amount || !bestVault || isDepositing}
+        disabled={
+          !amount ||
+          !bestVault ||
+          isDepositing ||
+          parseFloat(amount) <= 0 ||
+          Number.isNaN(parseFloat(amount))
+        }
         className="w-full rounded-xl bg-emerald-600 hover:bg-emerald-500 disabled:bg-gray-800 disabled:text-gray-600 text-white text-sm font-semibold py-3.5 transition-all duration-150 disabled:cursor-not-allowed"
       >
         {isDepositing ? t("vaultPanel.waiting") : t("vaultPanel.deposit")}
diff --git a/apps/web/src/components/dashboard/WithdrawTab.tsx b/apps/web/src/components/dashboard/WithdrawTab.tsx
index 764fa2b0..6e1edcf0 100644
--- a/apps/web/src/components/dashboard/WithdrawTab.tsx
+++ b/apps/web/src/components/dashboard/WithdrawTab.tsx
@@ -58,6 +58,8 @@ export function WithdrawTab({
               !amount ||
               !bestVault ||
               isWithdrawing ||
+              parseFloat(amount) <= 0 ||
+              Number.isNaN(parseFloat(amount)) ||
               parseFloat(amount) > (position?.shares ?? 0)
             }
             className="w-full rounded-xl bg-emerald-600 hover:bg-emerald-500 disabled:bg-gray-800 disabled:text-gray-600 text-white text-sm font-semibold py-3.5 transition-all duration-150 disabled:cursor-not-allowed"