Skip to content

[Chore] Reconcile V2_RESOLUTION.md's open design questions against the shipped v2 implementation #115

Description

@collinsezedike

Summary

docs/src/V2_RESOLUTION.md is a design proposal doc: its status banner reads "Proposed; design-only and not implemented," and it closes with "Until those economic choices are approved and threat-modeled, this proposal must remain Proposed and no implementation issue should treat its interface sketch as final." But tholos-v2 has since been fully implemented (contracts/tholos-v2, with a full test suite and now a complete interface reference in CONTRACT_V2.md, see #104). The doc was never updated to reflect that.

The doc lists 9 open "Questions for design review" (starting around line 681). At least two are confirmably answered by the shipped code:

  • Question 2 ("Should the minimum external position always equal the base assertion bond, or be a separately pinned parameter?"): resolved as "always equal to base_bond" (contracts/tholos-v2/src/lib.rs:700).
  • Question 3 (anti-sniping extension qualification and hard maximum): resolved by the shipped anti_snipe_extension_secs/anti_snipe_hard_max_secs parameters.

The other 7 questions haven't been checked against the implementation.

Scope

  • Go through each of the 9 open questions and determine whether the shipped tholos-v2 implementation answers it, and if so, how.
  • Update the status banner to reflect that implementation happened (no longer purely "Proposed").
  • Update or remove the closing "must remain Proposed" statement accordingly.
  • For any question the implementation doesn't actually resolve (a genuine remaining ambiguity, or a place where the code made an implicit choice worth documenting explicitly), note that too rather than assuming everything got answered.

Proposed approach

Read contracts/tholos-v2/src/lib.rs question by question against the design doc, the same way CONTRACT_V2.md (#104) was written by checking every claim against source rather than restating doc comments. This is closer to CONTRACT_V2.md's scope than a quick doc tweak, budget accordingly.

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third CampaignchoreDependency bumps, CI/tooling tweaks, docs-only changes, and cleanup that isn't a new capabilitymediumModerate scope or risk

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions