Settlement/Webhook/BlockchainWallet entities lack FK indexes

[martinzhames]

Category: tech-debt

Problem

None of src/settlements/entities/settlement.entity.ts (merchantId), src/webhooks/entities/webhook.entity.ts (merchantId), or src/blockchain-wallet/entities/blockchain-wallet.entity.ts (stellarAddress/userId are unique but every other query path, e.g. by status) has explicit @Index decorators — compare with src/groups/entities/group.entity.ts and src/notifications/entities/notification-preference.entity.ts, which do use @Index.

Impact

Inconsistent indexing strategy across the entity layer: some modules were clearly built with query performance in mind and others weren't, which will surface as slow admin/merchant list queries once these tables have production-scale row counts.

Suggested fix

Audit all 23 entities' actual query patterns (services' where clauses) against their @Index coverage and add a migration that backfills the missing ones, particularly settlements.merchantId and webhooks.merchantId.

[Ishola001]

@Ishola001 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello Maintainer. I can quickly work on this issue now. Kindly assign it to me.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ishola001 to this issue.

[emmyafolly123-coder]

@emmyafolly123-coder has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Settlement/Webhook/BlockchainWallet entities lack FK indexes
#149

ℹ️ Repo Maintainers: To accept this application, review their application or assign @emmyafolly123-coder to this issue.

[Emelie-Dev]

@Emelie-Dev has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi, I would love to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Emelie-Dev to this issue.

[DonaldXoftDev]

@DonaldXoftDev has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi, can I take this? please assign to me 🙏🙏

ℹ️ Repo Maintainers: To accept this application, review their application or assign @DonaldXoftDev to this issue.

[james2177]

@james2177 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

hi maintainer, can you please assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @james2177 to this issue.

[drips-wave]

Congratulations, @james2177! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @james2177: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊