From ee8d56a24be386fae9204b4056413e605fd34ddf Mon Sep 17 00:00:00 2001 From: nialljames Date: Mon, 19 Jan 2026 11:58:07 +0000 Subject: [PATCH] remove Herodotus logger --- CHANGELOG.md | 5 +++++ dvla-browser-drivers.gemspec | 1 - lib/dvla/browser/drivers.rb | 3 --- lib/dvla/browser/drivers/meta_drivers.rb | 6 +++--- lib/dvla/browser/drivers/version.rb | 2 +- 5 files changed, 9 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b80b376..e4cbf9b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,11 @@ # Changelog All notable changes to this project will be documented in this file. + +# [3.1.2] - 2026-01-19 + +- Remove dvla-herodotus dependency + # [3.1.1] - 2025-12-12 - Add selenium_safari config diff --git a/dvla-browser-drivers.gemspec b/dvla-browser-drivers.gemspec index b43aade..a0f5ff1 100644 --- a/dvla-browser-drivers.gemspec +++ b/dvla-browser-drivers.gemspec @@ -48,6 +48,5 @@ Gem::Specification.new do |spec| spec.add_dependency 'apparition', '>= 0.6' spec.add_dependency 'capybara', '>= 3.37' spec.add_dependency 'cuprite', '>= 0.14' - spec.add_dependency 'dvla-herodotus', '>= 2.0' spec.add_dependency 'selenium-webdriver', '>= 4.0' end diff --git a/lib/dvla/browser/drivers.rb b/lib/dvla/browser/drivers.rb index 1f5b7d4..81f5edc 100644 --- a/lib/dvla/browser/drivers.rb +++ b/lib/dvla/browser/drivers.rb @@ -3,11 +3,8 @@ require 'capybara/apparition' require 'capybara/cuprite' -require 'dvla/herodotus' require 'selenium-webdriver' module DVLA class Error < StandardError; end - - LOG = DVLA::Herodotus.logger('browser-drivers') end diff --git a/lib/dvla/browser/drivers/meta_drivers.rb b/lib/dvla/browser/drivers/meta_drivers.rb index 50f26d2..41dab99 100644 --- a/lib/dvla/browser/drivers/meta_drivers.rb +++ b/lib/dvla/browser/drivers/meta_drivers.rb @@ -27,7 +27,7 @@ def self.method_missing(method, *args, **kwargs, &) browser = browser_match.to_sym kwargs.each do |key, _value| - LOG.warn { "Key: '#{key}' will be ignored | Use one from: '#{SELENIUM_ACCEPTED_PARAMS}'" } unless SELENIUM_ACCEPTED_PARAMS.include?(key) + puts "Key: '#{key}' will be ignored | Use one from: '#{SELENIUM_ACCEPTED_PARAMS}'" unless SELENIUM_ACCEPTED_PARAMS.include?(key) end ::Capybara.register_driver method do |app| @@ -62,7 +62,7 @@ def self.method_missing(method, *args, **kwargs, &) end else kwargs.each do |key, _value| - LOG.warn { "Key: '#{key}' will be ignored | Use one from: '#{OTHER_ACCEPTED_PARAMS}'" } unless OTHER_ACCEPTED_PARAMS.include?(key) + puts "Key: '#{key}' will be ignored | Use one from: '#{OTHER_ACCEPTED_PARAMS}'" unless OTHER_ACCEPTED_PARAMS.include?(key) end browser_options = { 'no-sandbox': nil, 'disable-smooth-scrolling': true } @@ -82,7 +82,7 @@ def self.method_missing(method, *args, **kwargs, &) end end - LOG.info { "Driver set to: '#{method}'" } + puts "Driver set to: '#{method}'" ::Capybara.javascript_driver = method ::Capybara.default_driver = method diff --git a/lib/dvla/browser/drivers/version.rb b/lib/dvla/browser/drivers/version.rb index d00e8f5..2df89d4 100644 --- a/lib/dvla/browser/drivers/version.rb +++ b/lib/dvla/browser/drivers/version.rb @@ -3,7 +3,7 @@ module DVLA module Browser module Drivers - VERSION = '3.1.1' + VERSION = '3.1.2' end end end