From 87dbabf31bf5db827d4abeede9827b474d75ece5 Mon Sep 17 00:00:00 2001 From: Thomas Neidhart Date: Mon, 11 May 2026 15:03:43 +0200 Subject: [PATCH] fix: exclude displayName check in package.json validation --- .../publish/PublishExtensionVersionHandler.java | 8 +++++--- .../publish/PublishExtensionVersionHandlerTest.java | 13 ------------- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/server/src/main/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.java b/server/src/main/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.java index 0cb146a7e..14dd66e69 100644 --- a/server/src/main/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.java +++ b/server/src/main/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandler.java @@ -236,9 +236,11 @@ private void validatePackageMetadata( throw new ErrorResultException("Extension version in extension.vsixmanifest and package.json does not match."); } - if (!Strings.CI.equals(extVersion.getDisplayName(), packageMetadata.displayName())) { - throw new ErrorResultException("Display name in extension.vsixmanifest and package.json does not match."); - } + // Do not check if the displayName property is equal as it is not fully understood yet how VS Code / vsce processes + // that property. There are some projects, where the value is `%displayName%` and publication will fail. + // if (!Strings.CI.equals(extVersion.getDisplayName(), packageMetadata.displayName())) { + // throw new ErrorResultException("Display name in extension.vsixmanifest and package.json does not match."); + // } } private void validateLicense(ExtensionProcessor processor, ExtensionVersion extVersion) { diff --git a/server/src/test/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandlerTest.java b/server/src/test/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandlerTest.java index 9bf680455..6c88a5f40 100644 --- a/server/src/test/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandlerTest.java +++ b/server/src/test/java/org/eclipse/openvsx/publish/PublishExtensionVersionHandlerTest.java @@ -275,19 +275,6 @@ void shouldFailWhenPackageJsonDoesNotMatchManifest() throws IOException { assertThatThrownBy(() -> handler.createExtensionVersion(processor, token, LocalDateTime.now(), false)) .isInstanceOf(ErrorResultException.class) .hasMessageContaining("Extension version in extension.vsixmanifest"); - - when(processor.getPackageMetadata()).thenReturn( - new ExtensionProcessor.PackageMetadata( - "publisher", - "demo", - "2.0.0", - "Demo Not OK" - ) - ); - - assertThatThrownBy(() -> handler.createExtensionVersion(processor, token, LocalDateTime.now(), false)) - .isInstanceOf(ErrorResultException.class) - .hasMessageContaining("Display name in extension.vsixmanifest"); } }