Skip to content

Commit e4b46fc

Browse files
authored
Remove unused feature set (#136)
1 parent cc68892 commit e4b46fc

2 files changed

Lines changed: 0 additions & 108 deletions

File tree

‎docs/maintenance.md‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,6 @@ it defines no features of its own.
117117
`extra_known_features` / `extra_enabled_features` (same mechanism as the
118118
sanitizers).
119119

120-
> **Known cleanup item:** `features/BUILD` also defines two `cc_feature_set`
121-
> targets (`linux` and `qnx`) that group the same features for
122-
> `requires_any_of`/`requires_all_of`-style constraints. Nothing in this
123-
> repository currently references them — `cc_toolchain_config`'s
124-
> `known_features`/`enabled_features` attributes require individual
125-
> `FeatureInfo`-providing labels, not a `cc_feature_set` grouping (see the
126-
> `compute_feature_lists()` docstring in `features/make_cc_features.bzl`).
127-
> These should either be wired to a consumer or removed.
128-
129120
## Common Gotchas
130121

131122
- runtime-specific toolchains may need extra include and link flags that do not

‎features/BUILD‎

Lines changed: 0 additions & 99 deletions
Original file line numberDiff line numberDiff line change
@@ -1,99 +0,0 @@
1-
# *******************************************************************************
2-
# Copyright (c) 2025 Contributors to the Eclipse Foundation
3-
#
4-
# See the NOTICE file(s) distributed with this work for additional
5-
# information regarding copyright ownership.
6-
#
7-
# This program and the accompanying materials are made available under the
8-
# terms of the Apache License Version 2.0 which is available at
9-
# https://www.apache.org/licenses/LICENSE-2.0
10-
#
11-
# SPDX-License-Identifier: Apache-2.0
12-
# *******************************************************************************
13-
14-
load("@rules_cc//cc/toolchains:feature_set.bzl", "cc_feature_set")
15-
16-
# Order mirrors templates/cc_toolchain_config.bzl.template's `features = [...]` list,
17-
# since feature order determines command-line flag order.
18-
cc_feature_set(
19-
name = "linux",
20-
all_of = [
21-
"//features/native/markers:no_legacy_features",
22-
"//features/native/compiler_library_search_paths",
23-
"//features/native/markers:dbg",
24-
"//features/native/unfiltered_compile_flags",
25-
"//features/native/markers:gnu11",
26-
"//features/native/default_compile_flags",
27-
"//features/native/random_seed",
28-
"//features/native/include_paths",
29-
"//features/native/preprocessor_defines",
30-
"//features/native/user_compile_flags",
31-
"//features/native/compiler_input_flags",
32-
"//features/native/compiler_output_flags",
33-
"//features/native/dependency_file",
34-
"//features/native/per_object_debug_info",
35-
"//features/native/includes",
36-
"//features/native/default_link_flags",
37-
"//features/native/archiver_flags",
38-
"//features/native/linker_param_file",
39-
"//features/native/library_search_directories",
40-
"//features/native/shared_flag",
41-
"//features/native/output_execpath_flags",
42-
"//features/native/runtime_library_search_directories",
43-
"//features/native/libraries_to_link",
44-
"//features/native/user_link_flags",
45-
"//features/native/linkstamps",
46-
"//features/native/fission_support",
47-
"//features/native/force_pic_flags",
48-
"//features/native/strip_debug_symbols",
49-
"//features/native/static_libgcc",
50-
"//features/native/fully_static_link",
51-
"//features/native/sysroot_link_flags",
52-
"//features/native/use_pthread",
53-
"//features/native/markers:opt",
54-
"//features/native/markers:supports_dynamic_linker",
55-
"//features/native/markers:supports_pic",
56-
"//features/native/pic",
57-
"//features/native/markers:supports_header_path_normalization",
58-
"//features/native/markers:supports_fission",
59-
"//features/native/markers:coverage",
60-
"//features/native/gcc_coverage_map_format",
61-
],
62-
visibility = ["//visibility:public"],
63-
)
64-
65-
# Order mirrors templates/cc_toolchain_config.bzl.template's `features = [...]` list,
66-
# since feature order determines command-line flag order.
67-
cc_feature_set(
68-
name = "qnx",
69-
all_of = [
70-
"//features/native/markers:dbg",
71-
"//features/native/markers:no_legacy_features",
72-
"//features/native/unfiltered_compile_flags",
73-
"//features/native/default_compile_flags",
74-
"//features/native/random_seed",
75-
"//features/native/include_paths",
76-
"//features/native/preprocessor_defines",
77-
"//features/native/user_compile_flags",
78-
"//features/native/compiler_input_flags",
79-
"//features/native/compiler_output_flags",
80-
"//features/native/markers:dependency_file_named_implicitly",
81-
"//features/native/dependency_file",
82-
"//features/native/default_link_flags",
83-
"//features/native/archiver_flags",
84-
"//features/native/linker_param_file",
85-
"//features/native/library_search_directories",
86-
"//features/native/shared_flag",
87-
"//features/native/output_execpath_flags",
88-
"//features/native/libraries_to_link",
89-
"//features/native/user_link_flags",
90-
"//features/native/markers:coverage",
91-
"//features/native/markers:opt",
92-
"//features/native/markers:supports_dynamic_linker",
93-
"//features/native/markers:supports_pic",
94-
"//features/native/pic",
95-
"//features/native/runtime_library_search_directories",
96-
"//features/native/gcc_coverage_map_format",
97-
],
98-
visibility = ["//visibility:public"],
99-
)

0 commit comments

Comments
 (0)