Skip to content

Zoom limits are not optional #441

Description

@NiklasRentzCAU

The zoom limits, as introduced in #356, force the configuration of some zoom limit, just overriding the zoom limits in the viewer options to zoomLimits: undefined will cause an error when zooming:

zoom.js:72 Uncaught TypeError: Cannot read properties of undefined (reading 'min')
    at ZoomMouseListener.processZoom (zoom.js:72:1)

We have a use case (the new top-down layout in ELK) that makes it sensible to zoom arbitrarily deep into hierarchical graphs, so no limit number can turn this off. I would propose that setting this option to undefined or the limit numbers to something like -1 causes the limits to be ignored entirely.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomerssprottyIssue concerning the main sprotty package

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions