[CRASH] - app crashing after local server address added and low security enabled

[eojjn]

Describe the bug

App crashes on start

To Reproduce

Edit server settings adding local network address of navidrome server
Enable low security (I have https for web facing address, http for local 😬)
Restart app

Environment

• Android device: pixel 7 pro
• Android OS version: 15
• App version: 4.17
• App variant: degoogled
• Other relevant details: navidrome on server in local network

Logs or Screenshots

java.lang.IllegalArgumentException: Expected URL scheme 'http' or 'https' but no scheme was found for null/r...
at Q4.x.c(SourceFile:916)
at retrofit2.Retrofit$Builder.baseUrl(SourceFile:7)
at R2.a.(SourceFile:136)
at H2.j.(SourceFile:17)
at com.cappielloantonio.tempo.viewmodel.H.d(SourceFile:31)
at m3.h0.D(SourceFile:305)
at androidx.fragment.app.w.R(SourceFile:27)
at androidx.fragment.app.U.f(SourceFile:206)
at androidx.fragment.app.U.k(SourceFile:178)
at androidx.fragment.app.N.A(SourceFile:1659)
at androidx.fragment.app.N.T(SourceFile:82)
at androidx.fragment.app.N.y(SourceFile:78)
at androidx.fragment.app.N.t(SourceFile:67)
at g.l.s(SourceFile:34)
at g.l.onStart(SourceFile:1)
at com.cappielloantonio.tempo.ui.activity.MainActivity.B(SourceFile:1)
at com.cappielloantonio.tempo.ui.activity.MainActivity.onStart(SourceFile:1)
at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1706)
at android.app.Activity.performStart(Activity.java:9122)
at android.app.ActivityThread.handleStartActivity(ActivityThread.java:4231)
at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:214)
at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:194)
at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:166)
at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:101)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2773)
at android.os.Handler.dispatchMessage(Handler.java:109)
at android.os.Looper.loopOnce(Looper.java:232)
at android.os.Looper.loop(Looper.java:317)
at android.app.ActivityThread.main(ActivityThread.java:8934)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)

Additional context

would be great if the app logs you out on such an error (I am now completely locked out and don't wanna wipe the appdata)
Also allowing differentiating between security on local address and web address
And choosing which local network the local address should be searched on, as seen in dsub2000

[tvillega]

The full log for your situation is on #758.

Enable low security (I have https for web facing address, http for local 😬)

Also allowing differentiating between security on local address and web address

Low security is not the absence of SSL, it is sending clear-text passwords over the Subsonic API instead of hashes for backward compatibility with old versions.

And choosing which local network the local address should be searched on, as seen in dsub2000

Tempus has to request location permission to read the WiFi network list and current connection of your phone.

---

@eddyizm please add a priority tag to this issue, the login logic is unsafe and causing a crash loop.

[eddyizm]

I have been looking at the login and the local address. I know there is a fork that does some better work at the login details and I think this could use a whole bunch of refactoring, like being completely locked out is one of the worst things of I've had to deal with as the end user as well.