[BUG] - Missing quick action buttons in notification tray

[Kurami32]

Describe the bug

Noticed that the quick action buttons (shuffle, heart, repeat) stopped showing in the notification tray.

Logs or Screenshots

The notification looks like this:

Expected behavior

Show buttons (this is an old screenshot):

To Reproduce

Play any song and see notification tray.

Environment

• Android device: Samsung A12
• Android OS version: Android 13
• App version: v4.19.1-dev
• App variant: degoogled

Additional context

Not sure when started happening or if is present in the stable/normal release.

[eddyizm]

I'm not seeing this but to be fair, I quickly moved off the build you have. The new pre-release is out, I don't think we touched that directly so I am curious to see if if you still see that. Perhaps it is an edge case of your settings combinations?

[tvillega]

I don't think we touched that directly so I am curious to see if if you still see that.

I was thinking the same, none of the recent PR's addressed this beyond the major refactor in #752 .

[Kurami32]

I am curious to see if if you still see that. Perhaps it is an edge case of your settings combinations?

Yup, I'm still seeing the same in v4.19.2-dev on fresh install, I doubt if could be a combination of settings cuz I run mostly with the defaults. Only things I changed were:

• Dark theme to amoled.
• Show audio quality.
• Show album detail.
• Show item rating, favorites.
• Transcoding on mobile data.
• Chronological order in search.
• Tiles to medium size.

[Kurami32]

Tried with the stable/prod apk (v4.19.0) with default settings, I see the same :(

[eddyizm]

Yeah that is so weird! I'm not seeing it on my device using the latest prerelease.

[Kurami32]

yeah... other apps (like YouTube or other music players) show their own actions just fine. Not sure why Tempus doesn't.

When I have time I'll try older versions to see if works.

[herrerad85]

I think I tracked down why the buttons disappear. It looks like a side effect of the media3 1.8 button APIs interacting with the #663 fix.

In BaseSessionCallback.onConnect, the media notification controller gets two things at once: setMediaButtonPreferences(prev, playPause, next), added in 3fa8220 to fix #663 so the transport buttons stay pinned, and the deprecated setCustomLayout(...) for shuffle/heart/repeat.

On media3 1.8, once setMediaButtonPreferences is set it drives the notification layout, and the deprecated setCustomLayout no longer gets the custom buttons into the notification. So the transport buttons stay (that part of #663 keeps working) but shuffle/heart/repeat drop out.

The fix I have moves the custom buttons into setMediaButtonPreferences as well, each pinned to CommandButton.SLOT_OVERFLOW, and drops setCustomLayout. The overflow slot keeps them from taking the next button's place, so #663 should stay fixed while the custom buttons come back.

One thing to be honest about before merging anything: I could not reproduce the split on emulators. An Android 13 and an Android 15 AOSP image both show the same notification here, and the session itself exposes all four custom buttons on both, so this really looks like a OneUI rendering difference (there is no OneUI emulator image to test against). I would rather have it confirmed on a real device first.

I could zip a debug build that @Kurami32 could side load and check the buttons are back on your A12? Not sure how y’all would want to try this out.

Let me know what you think and I will do it. I will be out all day tomorrow pretty much, but I can check in as much as I can.

[eddyizm]

Hi @herrerad85 that makes sense. I am curious though, why this is not showing up for anyone else though, I also have not been able to replicate it and can't figure out what sequence/circumstance surfaces this bug.

EDIT: hit enter too quickly. I wanted to say, that after I get a regular release out in the next few days, we can add this fix into the pre-release so we can test out against this and the AA update.

[herrerad85]

Sounds good.

I think why it only shows for some people is that it is not really some devices have the bug but some devices' notification rendering still honors the deprecated setCustomLayout, and others don't.

Once setMediaButtonPreferences is set (the #663 fix), media3 1.8 treats it as the source of truth for the notification, and whether the old setCustomLayout custom buttons still slip through seems to vary by OneUI / Android version. Your device honors the fallback, Kurami32's A12 does not. That is also why I could not repro it on AOSP emulators, and my S25 happens to honor the fallback too.

The reason I think this is the fix is, it stops depending on that deprecated path entirely. The shuffle/heart/repeat buttons go into setMediaButtonPreferences as SLOT_OVERFLOW, so they no longer rely on setCustomLayout being honored. So it should work across the devices that disagree today, rather than having to pin down exactly which OneUI build drops the fallback.

[Kurami32]

@herrerad85 sure I can test and see if fixes the issue!
If you can send an apk I can try, but if not point me on which branch of your fork is the fix. I can also build the app myself :p

[herrerad85]

It's on this branch here if you would like to try.

https://github.com/herrerad85/tempus/tree/fix/notification-custom-buttons-787

[Kurami32]

Thanks, will try when I can! Right now I'm a bit busy.