Bug introduced in `4.1.4` related to `file_dep`

[oskarsari]

After updating to version 4.1.4, file uploads in my application are broken. The traceback seems to point to the changes made related to file_dep in the recently merged PR. This is how I initiate my router:

file_upload_router = create_tus_router(
    files_dir=runtime.env.path("temp"),
    upload_complete_dep=get_upload_handler,
    prefix="api/file/upload",
)

And this is the error I get when trying to upload a file:

 /python3.12/site-packages/fastapi/rou │
│ ting.py:212 in run_endpoint_function                                         │
│                                                                              │
│    209 │   assert dependant.call is not None, "dependant.call must be a func │
│    210 │                                                                     │
│    211 │   if is_coroutine:                                                  │
│ ❱  212 │   │   return await dependant.call(**values)                         │
│    213 │   else:                                                             │
│    214 │   │   return await run_in_threadpool(dependant.call, **values)      │
│    215                                                                       │
│                                                                              │
│ /python3.12/site-packages/tuspyserver │
│ /routes/creation.py:92 in extension_creation_route                           │
│                                                                              │
│    89 │   │   if inspect.isawaitable(result):                                │
│    90 │   │   │   await result                                               │
│    91 │   │   uid = None                                                     │
│ ❱  92 │   │   file_result = file_dep(metadata)                               │
│    93 │   │   file_options = deepcopy(options)                               │
│    94 │   │   # if the callback returned a coroutine, await it               │
│    95 │   │   if inspect.isawaitable(file_result):                           │
╰──────────────────────────────────────────────────────────────────────────────╯
TypeError: create_tus_router.<locals>._fallback_file_dep() takes 0 positional
arguments but 1 was given

Unfortunately right now I don't have time to debug this myself, so don't have a fix to suggest.

[edihasaj]

I'll have a look

[edihasaj]

can you try in v4.1.5 if it is fixed now? @oskarsari

[oskarsari]

can you try in v4.1.5 if it is fixed now? @oskarsari

@edihasaj Hmm, I still get the same error in 4.1.5

[edihasaj]

ok I saw some validation issues, can you test version 4.1.6 please!

[oskarsari]

ok I saw some validation issues, can you test version 4.1.6 please!

@edihasaj I still get the same error. Does it work for you? So far 4.1.3 seems like the last working release.

I tried to change my router initialization like this, to imitate the "fallback file dep":

file_upload_router = create_tus_router(
    files_dir=runtime.env.path("temp"),
    upload_complete_dep=get_upload_handler,
    prefix="api/sample/file/upload",
    file_dep=lambda *_: None,
)

And I get a different error:

────────────────────────────────╮
│ \.venv\Lib\site-packages\starlette\_exception_handl │
│ er.py:42 in wrapped_app                                                                          │
│                                                                                                  │
│   39 │   │   │   await send(message)                                                             │
│   40 │   │                                                                                       │
│   41 │   │   try:                                                                                │
│ ❱ 42 │   │   │   await app(scope, receive, sender)                                               │
│   43 │   │   except Exception as exc:                                                            │
│   44 │   │   │   handler = None                                                                  │
│   45                                                                                             │
│                                                                                                  │
│ \.venv\Lib\site-packages\starlette\routing.py:73 in │
│ app                                                                                              │
│                                                                                                  │
│    70 │   │   request = Request(scope, receive, send)                                            │
│    71 │   │                                                                                      │
│    72 │   │   async def app(scope: Scope, receive: Receive, send: Send) -> None:                 │
│ ❱  73 │   │   │   response = await f(request)                                                    │
│    74 │   │   │   await response(scope, receive, send)                                           │
│    75 │   │                                                                                      │
│    76 │   │   await wrap_app_handling_exceptions(app, request)(scope, receive, send)             │
│                                                                                                  │
│ \.venv\Lib\site-packages\fastapi\routing.py:346 in  │
│ app                                                                                              │
│                                                                                                  │
│    343 │   │   │   │   validation_error = RequestValidationError(                                │
│    344 │   │   │   │   │   _normalize_errors(errors), body=body                                  │
│    345 │   │   │   │   )                                                                         │
│ ❱  346 │   │   │   │   raise validation_error                                                    │
│    347 │   │   if response is None:                                                              │
│    348 │   │   │   raise FastAPIError(                                                           │
│    349 │   │   │   │   "No response object was returned. There's a high chance that the "        │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
RequestValidationError: [{'type': 'missing', 'loc': ('query', '_'), 'msg': 'Field required', 'input': None}]

Not sure if this is of any help.

[edihasaj]

that is helpful, I think I understand more now also, it is different issue from the changes I made earlier, I can test but I am testing different cases maybe I don't have your identical ENV, but if you check the code I also wrote some tests to check different cases, let me get back to you soon

[edihasaj]

@oskarsari can you please check version 4.1.7?