-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Your library is great, the API has great potential to kickstart my prototyping attempts around boost::beast which I find it has a very low level API.
However I have a piece of advice:
Can you amend the CMakeLists.txt file in such a way it does not depend on conan anymore?
- You can use find_package in CMakeLists.txt for Boost (https://cmake.org/cmake/help/v3.8/module/FindBoost.html), this way I can point it to local version of Boost via the BOOST_ROOT variable.
- You can do the same for OpenSSL (https://cmake.org/cmake/help/v3.8/module/FindOpenSSL.html)
- Any other dependency package it as a submodule inside the repository (especially since I see that the toolbox library can be built via CMake so add_subdirectory should fit the bill!)
Would love to hear your thoughts
Metadata
Metadata
Assignees
Labels
No labels