From 99e9ae35ce8b14baf7fbd7554970fad21f8611db Mon Sep 17 00:00:00 2001 From: Nicklas Sigurdh Date: Mon, 17 May 2021 14:56:31 +0200 Subject: [PATCH] added validation for numbers when creating a cell with numbers --- __test__/formatters/cells/generatorNumberCell.spec.js | 6 ++++++ src/formatters/cells/generatorNumberCell.js | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/__test__/formatters/cells/generatorNumberCell.spec.js b/__test__/formatters/cells/generatorNumberCell.spec.js index e60effc..2382744 100644 --- a/__test__/formatters/cells/generatorNumberCell.spec.js +++ b/__test__/formatters/cells/generatorNumberCell.spec.js @@ -1,9 +1,15 @@ import generatorNumberCell from '../../../src/formatters/cells/generatorNumberCell'; export const expectedXML = '1000'; +export const expectedErrorXML = 'NaN'; describe('Cell of type Number', () => { it('Should create a new xml markup cell', () => { expect(generatorNumberCell(0, 1000, 1)).toBe(expectedXML); }); + + it('Should create a new xml markup cell with NaN when there is not a number', () => { + expect(generatorNumberCell(0, 'text', 1)).toBe(expectedErrorXML); + }); }); + diff --git a/src/formatters/cells/generatorNumberCell.js b/src/formatters/cells/generatorNumberCell.js index 7c2612c..13100ee 100644 --- a/src/formatters/cells/generatorNumberCell.js +++ b/src/formatters/cells/generatorNumberCell.js @@ -1,3 +1,7 @@ import generatorCellNumber from '../../commons/generatorCellNumber'; -export default (index, value, rowIndex) => (`${value}`); +export default (index, value, rowIndex) => (`${validateNumber(value)}`); + +const validateNumber = (value) => { + return (isNaN(value))? 'NaN' : value; +} \ No newline at end of file