From 678c6ee3f030cdc54cbba7c32f1e86b7b2bcba8a Mon Sep 17 00:00:00 2001 From: Prud'homme Date: Thu, 13 Aug 2026 17:00:42 +0200 Subject: [PATCH 1/2] ci: bump actions off the deprecated Node.js 20 runtime MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Every run warned that these actions target Node.js 20 and were being forced onto Node 24. That fallback is temporary, so move to the majors that declare node24 natively. Mechanical: no workflow logic changes, and nothing here affects what the app is built with — the `node-version` bump is a separate commit so a build regression is easy to bisect. Refs #24 Claude-Session: https://claude.ai/code/session_01NcJuB2iR4WEfuQVLpYqWi4 --- .github/workflows/ci.yml | 20 ++++++++++---------- .github/workflows/docs.yml | 8 ++++---- .github/workflows/release.yml | 16 ++++++++-------- 3 files changed, 22 insertions(+), 22 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 077051b..a7f52b6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,9 +11,9 @@ jobs: name: Test runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v7 with: node-version: 20 cache: npm @@ -25,9 +25,9 @@ jobs: name: Type Check runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v7 with: node-version: 20 cache: npm @@ -39,9 +39,9 @@ jobs: name: Build (macOS) runs-on: macos-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v7 with: node-version: 20 cache: npm @@ -55,7 +55,7 @@ jobs: - run: npm ci - run: npx tauri build --no-sign - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v7 with: name: macos-app path: | @@ -66,9 +66,9 @@ jobs: name: Build (Windows) runs-on: windows-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v7 with: node-version: 20 cache: npm @@ -82,7 +82,7 @@ jobs: - run: npm ci - run: npx tauri build --no-sign - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v7 with: name: windows-app path: | diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index b902502..06d1282 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -21,9 +21,9 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v7 with: node-version: 20 cache: npm @@ -32,7 +32,7 @@ jobs: - run: npx vitepress build docs - - uses: actions/upload-pages-artifact@v3 + - uses: actions/upload-pages-artifact@v5 with: path: docs/.vitepress/dist @@ -45,4 +45,4 @@ jobs: steps: - name: Deploy to GitHub Pages id: deployment - uses: actions/deploy-pages@v4 + uses: actions/deploy-pages@v5 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 96563dd..364432d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,9 +13,9 @@ jobs: name: Build macOS (Sign & Notarize) runs-on: macos-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v7 with: node-version: 20 cache: npm @@ -109,7 +109,7 @@ jobs: xcrun stapler staple "$DMG_PATH" echo "NOTARIZED=true" >> "$GITHUB_ENV" - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v7 with: name: macos-artifacts path: src-tauri/target/release/bundle/dmg/*.dmg @@ -118,9 +118,9 @@ jobs: name: Build Windows runs-on: windows-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v7 with: node-version: 20 cache: npm @@ -135,7 +135,7 @@ jobs: - run: npm test - run: npx tauri build - - uses: actions/upload-artifact@v4 + - uses: actions/upload-artifact@v7 with: name: windows-artifacts path: | @@ -147,13 +147,13 @@ jobs: needs: [build-macos, build-windows] runs-on: ubuntu-latest steps: - - uses: actions/download-artifact@v4 + - uses: actions/download-artifact@v8 with: path: artifacts merge-multiple: true - name: Create GitHub Release - uses: softprops/action-gh-release@v2 + uses: softprops/action-gh-release@v3 with: draft: false generate_release_notes: true From e9659e5f44121c287591b243c399fdac1e8604f3 Mon Sep 17 00:00:00 2001 From: Prud'homme Date: Thu, 13 Aug 2026 17:01:05 +0200 Subject: [PATCH 2/2] ci: build on Node.js 24 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Node 20 is end-of-life, so the version the app is actually built with follows the runtime bump. This is the part that carries real risk — it affects `npm ci`, the Vite build and the test run — hence its own commit. Tests, type check and the Vite build already run on Node 24 locally; CI covers the rest, in particular the Windows build and the macOS sign/notarize path. Closes #24 Claude-Session: https://claude.ai/code/session_01NcJuB2iR4WEfuQVLpYqWi4 --- .github/workflows/ci.yml | 8 ++++---- .github/workflows/docs.yml | 2 +- .github/workflows/release.yml | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a7f52b6..e6edcb9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: 20 + node-version: 24 cache: npm - run: npm ci @@ -29,7 +29,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: 20 + node-version: 24 cache: npm - run: npm ci @@ -43,7 +43,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: 20 + node-version: 24 cache: npm - uses: dtolnay/rust-toolchain@stable @@ -70,7 +70,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: 20 + node-version: 24 cache: npm - uses: dtolnay/rust-toolchain@stable diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 06d1282..4b40f40 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -25,7 +25,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: 20 + node-version: 24 cache: npm - run: npm ci diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 364432d..0f87daf 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,7 +17,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: 20 + node-version: 24 cache: npm - uses: dtolnay/rust-toolchain@stable @@ -122,7 +122,7 @@ jobs: - uses: actions/setup-node@v7 with: - node-version: 20 + node-version: 24 cache: npm - uses: dtolnay/rust-toolchain@stable