From e9fd2e8700a3d6b47a0e6cafa7b354729b555ebe Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Thu, 19 Mar 2026 14:31:13 -0400 Subject: [PATCH 1/2] chore: allow overriding main.star and backend.star --- src/utils/siso.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/utils/siso.js b/src/utils/siso.js index ac78624f..6b007874 100644 --- a/src/utils/siso.js +++ b/src/utils/siso.js @@ -34,7 +34,7 @@ function sisoFlags(config, hasExecute) { '-reapi_address', reclient.serviceAddress(config), '-load', - path.resolve(__dirname, '../../tools/main.star'), + process.env.ELECTRON_BUILD_TOOLS_MAIN_STAR || path.resolve(__dirname, '../../tools/main.star'), ]; if (!hasExecute) { @@ -54,7 +54,9 @@ async function ensureBackendStarlark(config) { ); } - const backendConfig = path.resolve(__dirname, '../../tools/backend.star'); + const backendConfig = + process.env.ELECTRON_BUILD_TOOLS_BACKEND_STAR || + path.resolve(__dirname, '../../tools/backend.star'); const starlarkPath = path.resolve(starlarkDir, 'backend.star'); let needsUpdate = true; if (fs.existsSync(starlarkPath)) { From 193d44817124bc546b7f2ab944ca29f6c7864703 Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Mon, 23 Mar 2026 11:48:09 -0400 Subject: [PATCH 2/2] chore: apply review feedback --- src/utils/siso.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/utils/siso.js b/src/utils/siso.js index 6b007874..b7f2b32b 100644 --- a/src/utils/siso.js +++ b/src/utils/siso.js @@ -21,6 +21,13 @@ const sisoEnv = (config) => { return sisoEnv; }; +function getStarFile(envVar, filename) { + if (process.env[envVar] && fs.existsSync(process.env[envVar])) { + return process.env[envVar]; + } + return path.resolve(__dirname, '../../tools', filename); +} + function sisoFlags(config, hasExecute) { if (config.remoteBuild !== 'siso') return []; @@ -34,7 +41,7 @@ function sisoFlags(config, hasExecute) { '-reapi_address', reclient.serviceAddress(config), '-load', - process.env.ELECTRON_BUILD_TOOLS_MAIN_STAR || path.resolve(__dirname, '../../tools/main.star'), + getStarFile('ELECTRON_BUILD_TOOLS_MAIN_STAR', 'main.star'), ]; if (!hasExecute) { @@ -54,9 +61,7 @@ async function ensureBackendStarlark(config) { ); } - const backendConfig = - process.env.ELECTRON_BUILD_TOOLS_BACKEND_STAR || - path.resolve(__dirname, '../../tools/backend.star'); + const backendConfig = getStarFile('ELECTRON_BUILD_TOOLS_BACKEND_STAR', 'backend.star'); const starlarkPath = path.resolve(starlarkDir, 'backend.star'); let needsUpdate = true; if (fs.existsSync(starlarkPath)) {