Skip to content

add simple enable and disable test for fkwp/feature_deepfilternet#3821

Closed
CrazyNicc wants to merge 3 commits into
element-hq:fkwp/feature_deepfilternetfrom
CrazyNicc:feature_deepfilternet_tests
Closed

add simple enable and disable test for fkwp/feature_deepfilternet#3821
CrazyNicc wants to merge 3 commits into
element-hq:fkwp/feature_deepfilternetfrom
CrazyNicc:feature_deepfilternet_tests

Conversation

@CrazyNicc
Copy link
Copy Markdown

@CrazyNicc CrazyNicc commented Mar 28, 2026 •
edited
Loading

Content

I added a simple enable and disable test for the fkwp/feature_deepfilternet branch (#3819 ), so that Code Coverage is happy.

Motivation and context

The original branch wasn't fulfilling the Code Coverage test, so I hope this fixes it

Checklist

  • I have read through CONTRIBUTING.md.
  • Pull request includes screenshots or videos if containing UI changes
  • Tests written for new code (and old code if feasible).
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@CrazyNicc CrazyNicc requested a review from a team as a code owner March 28, 2026 20:14
@CrazyNicc CrazyNicc requested review from Half-Shot and removed request for a team March 28, 2026 20:14
@CrazyNicc
Copy link
Copy Markdown
Author

CrazyNicc commented Mar 31, 2026

what exactly does the failing workflow need?

@fkwp
Copy link
Copy Markdown
Contributor

fkwp commented Mar 31, 2026

what exactly does the failing workflow need?

just a label

@fkwp fkwp added the PR-Feature Release note category. A PR that introduces a new user facing feature. label Mar 31, 2026
@fkwp fkwp force-pushed the fkwp/feature_deepfilternet branch 2 times, most recently from 19989fe to d52916d Compare April 7, 2026 11:11
@CrazyNicc
Copy link
Copy Markdown
Author

CrazyNicc commented Apr 9, 2026

The original branch now has tests and way more of them, so closing this now

@CrazyNicc CrazyNicc closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Half-Shot Half-Shot Awaiting requested review from Half-Shot Half-Shot is a code owner automatically assigned from element-hq/element-call-reviewers

Assignees

No one assigned

Labels

PR-Feature Release note category. A PR that introduces a new user facing feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CrazyNicc @fkwp