Always wait for local transport

[toger5]

Content

Motivation and context

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Checklist

• I have read through CONTRIBUTING.md.
• Pull request includes screenshots or videos if containing UI changes
• Tests written for new code (and old code if feasible).
• Linter and other CI checks pass.
• I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

[toger5]

We close this one since we believe @BillCarsonFr refactor PR is going to fix the same issue.
@BillCarsonFr Will close this PR and link it to the refactor.

[BillCarsonFr]

We close this one since we believe @BillCarsonFr refactor PR is going to fix the same issue. @BillCarsonFr Will close this PR and link it to the refactor.

If this fix was about the issue were you couldn't mute / unmute (3849), the bug was not that there was a double Connection for the same url, it was the opposite; There was no connection for the advertisedTransport (because it was oldestmembership and the oldest was not using the one advertised).

While investigating, I needed to add more logs, and I found the ConnectionManager too complex for what it was doing so I started to break it down a bit, and remove the generateItem things as I found it not helping to understand what was happening to connections...

I'll push the refactoring/cleaning to see if we agree that it makes it easier to understanf