Skip to content

refactor: grug down the connection manager #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BillCarsonFr wants to merge 2 commits into
base: livekit
Choose a base branch
from
Open

refactor: grug down the connection manager #3873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a95d77b
refactor: grug down the connection manager
BillCarsonFr Apr 14, 2026
34ca911
Merge branch 'livekit' into valere/devx/refactor_connection_manager
BillCarsonFr Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/state/CallViewModel/remoteMembers/ConnectionManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ beforeEach(() => {
transport,
remoteParticipants$: new BehaviorSubject([]),
} as unknown as Connection;
vi.mocked(mockConnection).start = vi.fn();
vi.mocked(mockConnection).start = vi.fn().mockResolvedValue(undefined);
vi.mocked(mockConnection).stop = vi.fn();
// Tie the connection's lifecycle to the scope to test scope lifecycle management
scope.onEnd(() => {
Expand Down Expand Up @@ -235,7 +235,9 @@ describe("connectionManagerData$ stream", () => {
transport,
remoteParticipants$: getRemoteParticipantsFor(transport),
} as unknown as Connection;
vi.mocked(mockConnection).start = vi.fn();
vi.mocked(mockConnection).start = vi
.fn()
.mockResolvedValue(undefined);
vi.mocked(mockConnection).stop = vi.fn();
// Tie the connection's lifecycle to the scope to test scope lifecycle management
scope.onEnd(() => {
Expand Down
Loading
Loading