Images manually made visibile forget they were visible when re-entering the room

[Susurrus]

Steps to reproduce

1. Set the "Show media in timeline" setting to "in private rooms"
2. Go to a public chatroom with media (e.g. #off-topic:gnome.org)
3. Find an image and click Show
4. Go back to the room list
5. Go back to the room and find the image again and it'll be hidden

This would be less of an issue if the "show media in timeline" option had a per-room override in addition to a global setting. I've realized that I'm only in rooms that ban media, or heavily moderate them, so I've just switched to showing them all by default to workaround this.

Outcome

What did you expect?

The image to stay visible after I clicked Show once

What happened instead?

It was re-hidden after leaving the room.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes