This issue has been migrated from #16650.
Base: develop
This pull request is intended for commit-by-commit review.
Original commit schedule, with full messages:
-
Remove obsolete "app" from worker templates
-
Convert worker templates into dataclass
-
Use a lambda for the worker name rather than search and replace later
-
Collapse WORKERS_CONFIG by removing entries with defaults
-
Convert listener_resources and endpoint_patterns to Set[str]
-
Tweak comments
-
Add merge_into
-
Remove special logic for adding stream_writers: just make it part of the extra config template
-
Rename function to add_worker_to_instance_map given reduction of scope
-
Add sharding_allowed to the WorkerTemplate rather than having a separate function for that
-
Use merge_into when adding workers to the shared config
-
Promote mark_filepath to constant
-
Add a --generate-only option
This issue has been migrated from #16650.
Base:
developThis pull request is intended for commit-by-commit review.
Original commit schedule, with full messages:
Remove obsolete
"app"from worker templatesConvert worker templates into dataclass
Use a lambda for the worker name rather than search and replace later
Collapse WORKERS_CONFIG by removing entries with defaults
Convert listener_resources and endpoint_patterns to Set[str]
Tweak comments
Add
merge_intoRemove special logic for adding stream_writers: just make it part of the extra config template
Rename function to add_worker_to_instance_map given reduction of scope
Add
sharding_allowedto the WorkerTemplate rather than having a separate function for thatUse
merge_intowhen adding workers to the shared configPromote mark_filepath to constant
Add a --generate-only option