Initial integration fixes#2
Merged
Merged
Conversation
The driver adheres to the power-supply framework, and property name (for the maximum charge current that may be requested) is `POWER_SUPPLY_CONSTANT_CHARGE_CURRENT_MAX`. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch main # Your branch is up to date with 'origin/main'. # # Changes to be committed: # modified: src/supply.rs # # Changes not staged for commit: # modified: Cargo.toml # modified: debian/service # # Untracked files: # Cargo.toml~ # debian/service~ # src/supply.rs~ #
Moved install location to the directory for things that run as root. Also, tweak the extended-description to be clear that we only initiate a shutdown when power has failed *and* the threshold condition is met. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch main # Your branch is ahead of 'origin/main' by 1 commit. # (use "git push" to publish your local commits) # # Changes to be committed: # modified: Cargo.toml # # Changes not staged for commit: # modified: debian/service # # Untracked files: # Cargo.toml~ # debian/service~ # src/supply.rs~ #
The service should find `silod` in `/usr/sbin`, which is the directory for things that run as root. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch main # Your branch is ahead of 'origin/main' by 1 commit. # (use "git push" to publish your local commits) # # Changes to be committed: # modified: Cargo.toml # # Changes not staged for commit: # modified: debian/service # # Untracked files: # Cargo.toml~ # debian/service~ # src/supply.rs~ #
Contributor
Author
|
Also, it isn't yet clear why |
ts-kris
approved these changes
Sep 2, 2025
ts-kris
left a comment
ts-kris
left a comment
There was a problem hiding this comment.
Changes look reasonable to me based on prior discussions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes needed before silod can be expected to integrate successfully and ship as a Debian package.