diff --git a/bin/benchmark/run.mjs b/bin/benchmark/run.mjs index a31d121e975..04c7c8b929d 100644 --- a/bin/benchmark/run.mjs +++ b/bin/benchmark/run.mjs @@ -171,24 +171,6 @@ async function bootAndRun({ headless = true } = {}) { '--debug', '--browserArgs', [ - '--no-sandbox', - '--crash-dumps-dir=./tmp', - // Disable task throttling (also in TracerBench defaults, but explicit here for clarity) - '--disable-background-timer-throttling', - '--disable-backgrounding-occluded-windows', - '--disable-renderer-backgrounding', - // Disable caching and unnecessary subsystems - '--disable-dev-shm-usage', - '--disable-cache', - '--disable-v8-idle-tasks', - '--disable-breakpad', - '--disable-component-update', - '--disable-background-networking', - '--disable-notifications', - '--disable-hang-monitor', - '--safebrowsing-disable-auto-update', - '--ignore-certificate-errors', - '--v8-cache-options=none', // Use the new headless mode to support multiple targets ...(headless ? ['--headless=new'] : []), // GPU: use software rendering via SwiftShader, but do NOT @@ -196,11 +178,6 @@ async function bootAndRun({ headless = true } = {}) { // as the contradictory flags cause use-after-free crashes on macOS '--disable-gpu', '--disable-gpu-compositing', - // Disable Chrome ML/TFLite features (suppresses XNNPACK/TFLite init) - '--disable-features=TranslateUI', - '--disable-features=UseChromiumML', - '--disable-features=UseTfLite', - '--disable-features=TensorFlowLite', ].join(','), ]; diff --git a/patches/@tracerbench__core@8.0.1.patch b/patches/@tracerbench__core@8.0.1.patch index fa9b0967701..1a551f68662 100644 --- a/patches/@tracerbench__core@8.0.1.patch +++ b/patches/@tracerbench__core@8.0.1.patch @@ -1,15 +1,60 @@ diff --git a/dist/create-trace-benchmark.js b/dist/create-trace-benchmark.js -index 5918e8f7665b3e796ef88283fc40c2b3286a564f..e1a8768964de8b3c16d38bfb6280d836b45aba0b 100644 +index 5918e8f7665b3e796ef88283fc40c2b3286a564f..b9927ba8f639c0a9ecc70144362da439468f1b3a 100644 --- a/dist/create-trace-benchmark.js +++ b/dist/create-trace-benchmark.js -@@ -45,9 +45,8 @@ function createTraceBenchmark(group, sampleTrace, options = {}) { +@@ -45,35 +45,27 @@ function createTraceBenchmark(group, sampleTrace, options = {}) { } exports.default = createTraceBenchmark; function getCategories(isTrial, options) { - const categories = ['-*', ...defaultCategories]; -+ const categories = [...defaultCategories]; - if (isTrial) { +- if (isTrial) { - categories.push(...captureAllDevtoolsTimelineCategories, ...captureCpuProfileCategories, captureCpuProfilesHiresCategory, captureFilmStripCategory, ...capturePaintProfileCategories); - if (options.additionalTrialCategories) { - categories.push(...options.additionalTrialCategories); - } +- if (options.additionalTrialCategories) { +- categories.push(...options.additionalTrialCategories); +- } ++ const categories = [...defaultCategories]; ++ // include the basic disabled by default devtools categories ++ if (options.captureDevtoolsTimeline) { ++ categories.push(...captureDevtoolsTimelineCategories); + } +- else { +- // include the basic disabled by default devtools categories +- if (options.captureDevtoolsTimeline) { +- categories.push(...captureDevtoolsTimelineCategories); +- } +- if (options.captureV8RuntimeStats) { +- // this breaks devtools display of CPU profile in dev tools +- categories.push(...captureV8RuntimeStatsCategories); +- } +- if (options.captureCpuProfile) { +- // includes runtime samples +- categories.push(...captureCpuProfileCategories); +- } +- if (options.captureFilmStrip) { +- categories.push(captureFilmStripCategory); +- } +- if (options.capturePaintProfile) { +- categories.push(...capturePaintProfileCategories); +- } +- if (options.additionalCategories) { +- categories.push(...options.additionalCategories); +- } ++ if (options.captureV8RuntimeStats) { ++ // this breaks devtools display of CPU profile in dev tools ++ categories.push(...captureV8RuntimeStatsCategories); ++ } ++ if (options.captureCpuProfile) { ++ // includes runtime samples ++ categories.push(...captureCpuProfileCategories); ++ } ++ if (options.captureFilmStrip) { ++ categories.push(captureFilmStripCategory); ++ } ++ if (options.capturePaintProfile) { ++ categories.push(...capturePaintProfileCategories); ++ } ++ if (options.additionalCategories) { ++ categories.push(...options.additionalCategories); + } + return categories; + } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 7fb39f138db..1d3f416ec4e 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -11,7 +11,7 @@ overrides: patchedDependencies: '@tracerbench/core@8.0.1': - hash: 94ed69d4e124c0c94f1c1e3332668ae5d3265509b12cc97dd634feee8ed7e846 + hash: ee5cfa4adb0f65df07ef51d9be56c31150b4330d7ac7e1fbbb0a87329938af0a path: patches/@tracerbench__core@8.0.1.patch importers: @@ -16596,7 +16596,7 @@ snapshots: dependencies: defer-to-connect: 1.1.3 - '@tracerbench/core@8.0.1(patch_hash=94ed69d4e124c0c94f1c1e3332668ae5d3265509b12cc97dd634feee8ed7e846)': + '@tracerbench/core@8.0.1(patch_hash=ee5cfa4adb0f65df07ef51d9be56c31150b4330d7ac7e1fbbb0a87329938af0a)': dependencies: '@tracerbench/har': 8.0.0 '@tracerbench/trace-event': 8.0.0 @@ -24898,7 +24898,7 @@ snapshots: '@oclif/parser': 3.8.17 '@oclif/plugin-help': 5.2.20(@swc/core@1.15.18)(@types/node@22.19.15)(typescript@5.9.3) '@oclif/plugin-warn-if-update-available': 2.1.1(@swc/core@1.15.18)(@types/node@22.19.15)(typescript@5.9.3) - '@tracerbench/core': 8.0.1(patch_hash=94ed69d4e124c0c94f1c1e3332668ae5d3265509b12cc97dd634feee8ed7e846) + '@tracerbench/core': 8.0.1(patch_hash=ee5cfa4adb0f65df07ef51d9be56c31150b4330d7ac7e1fbbb0a87329938af0a) '@tracerbench/stats': 8.0.1 '@tracerbench/trace-event': 8.0.0 archiver: 5.3.2