implementations on project#685
Merged
emdevelopa merged 3 commits intoApr 23, 2026
Merged
Conversation
|
@Akatenvictor is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Akatenvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
WalletSelector Component
Visibility Fixes: Replaced hardcoded text-white with text-slate-900 dark:text-white. This ensures that text is visible on both light backgrounds (like the
PaymentPage
) and dark backgrounds (like the
PaymentDetailModal
).
Syntax Cleanup: Removed duplicate className property on the wallet provider buttons.
Icon Accessibility: Added aria-hidden="true" and role="img" to decorative icons to prevent screen readers from announcing them unnecessarily.
Theme Consistency: Updated borders, backgrounds, and focus states to use theme-aware Tailwind classes (pluto and mint scales), matching the Drips Wave aesthetic.
Contrast Improvements: Refined the WalletConnect QR code section and error messages to ensure high contrast in both light and dark modes.
Interactive Elements: Improved the Freighter install link with proper theme colors and hover states.
Modal Containers
Dark Mode forcing: Added the dark class to the main
Modal
and
PaymentDetailModal
containers. Since these components are hardcoded with dark backgrounds, they must also signal the "dark" context to their children so that theme-aware components (like
WalletSelector
) correctly render their dark variants.
Verification Results
Visual Verification
Verified that text is clearly readable in the
PaymentPage
card (light theme).
Verified that text is correctly rendered as white in the
PaymentDetailModal
(dark theme).
Verified that all icons are properly hidden from screen readers but remains visible for sighted users.
Closes #548
Closes #560
Closes #562
Closes #572