Skip to content

FEAT-044.md

Latest commit

 

History

History
92 lines (70 loc) · 3.81 KB

FEAT-044.md

File metadata and controls

92 lines (70 loc) · 3.81 KB
Raw
id FEAT-044
workflow github
github_issue emulebb/emulebb#18
title IP filter input policy - PeerGuardian lists, whitelist, and private-IP exemption
status OPEN
priority Minor
category feature
labels
ipfilter
security
peerguardian
whitelist
private-ip
emuleai
milestone
created 2026-04-26
source eMuleAI IPFilter comparison and historical mod scan

Workflow status is tracked in GitHub: emulebb/emulebb#18. This local document is retained as an engineering spec/evidence record.

FEAT-044 - IP filter input policy - PeerGuardian lists, whitelist, and private-IP exemption

Summary

Extend the now-safe IP-filter update foundation with optional input-policy improvements from eMuleAI and historical mods:

  • load and merge PeerGuardian *.p2p lists from the config directory
  • support a static/admin-managed filter overlay
  • support a whitelist that overrides blacklist matches
  • optionally avoid filtering private/local addresses for lab and LAN use

Current Main Evidence

Current emulebb-main has:

  • safe manual IP-filter promotion
  • FEAT-042 automatic IP-filter update scheduling
  • reload of the running CIPFilter instance after successful promotion

It does not yet have *.p2p config-directory merge, whitelist override, static overlay, or a private-IP filtering preference.

eMuleAI Reference

analysis\emuleai\srchybrid\IPFilter.cpp/h includes:

  • LoadP2PFiles()
  • .p2p and guarding.p2p parsing
  • AddFromFileStatic(...)
  • AddFromFileWhite(...)
  • DontFilterPrivateIPs handling in IsFiltered(...)

The eMuleAI code is useful as behavior reference, but should not be copied wholesale without reconciling BUG-004 overlap semantics and current safe promotion helpers.

GitHub references from eMuleAI commit 8e34bdec2b7e4fe9e4307df9d80f691804be99ed:

Stock/Community Comparison

Stock/community 0.72 remains closer to the single ipfilter.dat model. This is an optional security/operations feature for users who already maintain richer filter sources.

Scope Constraints

  • build on the safe download/promotion/reload path from BUG-027 and FEAT-042
  • decide explicit precedence among whitelist, static filter, downloaded filter, and manual imports
  • preserve the existing disabled-by-default auto-update posture
  • do not silently trust bundled external lists; keep sources user-configured
  • coordinate with BUG-004 before claiming full IP-filter correctness

Acceptance Criteria

  • *.p2p parsing is covered by unit tests with PeerGuardian-style samples
  • whitelist precedence is deterministic and documented
  • private/LAN exemption is explicit, persisted, and default-safe
  • malformed or empty inputs cannot clear the live filter
  • live reload semantics match manual and scheduled update paths
  • GitHub-linked eMuleAI reference behavior is covered by deterministic local tests before enabling each policy source