Skip to content

REF-044.md

Latest commit

 

History

History
74 lines (56 loc) · 2.8 KB

REF-044.md

File metadata and controls

74 lines (56 loc) · 2.8 KB
Raw
id REF-044
workflow github
github_issue emulebb/emulebb#100
title Remove remaining import-parts residue and keep legacy import flows retired
status OPEN
priority Minor
category refactor
labels
import-parts
feature-removal
file-handling
cleanup
resources
milestone post-0.7.3
created 2026-05-21
source upstream issue triage; user direction to drop import-parts

Workflow status is tracked in GitHub: emulebb/emulebb#100. This local document is retained as an engineering spec/evidence record.

REF-044 - Remove remaining import-parts residue and keep legacy import flows retired

Summary

Keep the legacy import-parts direction retired and remove remaining code, resource, string, and documentation residue that can make the surface look supported.

FEAT-033 already removed the old PartFileConvert import flow from the active app build and UI path. This follow-up is about closing any leftover affordances or helper paths that still invite maintenance of import-parts behavior.

Current Mainline Evidence

The active tree still contains import-oriented residue such as:

  • IDS_IMPORTPARTS_* and IDS_IMPORTSPLPF strings in srchybrid/emule.rc and translated resource files;
  • FILEIMPORTPARTS icon resource references;
  • import-specific comments and helper names around part-file write and Shareaza temp-file intake.

Some of these may be harmless remnants, and some may support distinct legacy intake cases. The implementation should audit before deleting, but the product decision is clear: do not restore or repair a user-facing Import Parts workflow.

Scope

  • Remove stale Import Parts menu strings, icons, and translated rows when no live UI uses them.
  • Remove dead helper paths that only served the retired import workflow.
  • Keep ordinary eD2K link intake and normal part-file recovery behavior intact.
  • Record any intentionally retained non-UI compatibility helper with a clear comment and no user-visible Import Parts promise.

Non-Goals

  • Do not add a replacement import wizard.
  • Do not change normal download, resume, hash, AICH, or completion semantics.
  • Do not delete unrelated archive recovery or preview-copy behavior.

Upstream Signal

eMuleAI issue #63 reports confusing Import Parts behavior where only one part imports from an external .part file. eMuleBB should avoid taking on that surface; it is a brittle legacy workflow and not part of the supported product direction.

Acceptance Criteria

  • No user-visible Import Parts command remains in menus, templates, or preferences.
  • Stale import-parts resources and translated strings are removed or explicitly justified.
  • Normal eD2K link intake still works.
  • Existing part-file persistence, completion, and AICH recovery tests still pass.