Skip to content

[BUG] Duplicate coverage merge requests for flight line badge updates #94

@espg

Description

@espg

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

This gh actions workflow automatically updates the flight line coverage for us-- which is done as a PR that requires manual approval. The problem is that if we don't merge the PR, the workflow will run again, see that the docs in master needs to be updated, and then submit another PR; i.e., not merging the #91 on Friday before the weekend means we duplicate requests #92 and #93 over the weekend.

The reason that we have the manual PR approval process is 1.) a historic holdover from how we were (not) provisioning merge privileges to bots on our main branch (which is protected), and 2.) as a sort of built in alert for us to notice when the coverage changes. The former issue is fixed in other workflows already, like our publish workflow that updates the changelog and commits to main directly before running the release packaging and push to pypi. The latter reason also seems less needed at this point given that we get slack message updates and can/do watch the repo in gh which emails on PR's.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions