Extra column classes defined

[jesusbagpuss]

Hi,
Just getting my head into the Bootstrap stuff (first dealings with it - I'm very green!).
From this: https://getbootstrap.com/examples/grid/,

Each tier of classes scales up, meaning if you plan on setting the same widths for xs and sm, you only need to specify xs.

Looking at e.g. https://github.com/eprintsug/bootstrap/blob/master/cfg/citations/eprint/bootstrap_summary_page.xml#L15,

<div id="summary_citation" class="col-lg-12 col-md-12 col-sm-12 col-xs-12 summary-widget">

could be

<div id="summary_citation" class="col-xs-12 summary-widget">

Am I understanding this right?

A different example from https://github.com/eprintsug/bootstrap/blob/master/cfg/citations/eprint/bootstrap_summary_page.xml#L13

<div id="summarypage_left" class="col-lg-7 col-md-7 col-sm-7 col-xm-12">

I think could be

<div id="summarypage_left" class="col-sm-7 col-xm-12">

If I'm understanding this right, I can make a PR with all of these in - unless they are there as placeholders?

[davidmce]

very likely completely correct! There is a lot of col-- code in here that is a legacy of me trying to workout the best way of getting stuff to fit, and isn't really needed anymore.
If you are willing to PR all of these then yeah.. I'm hoping to get my server soon and get back to this.