`failure_reason` in `starknet_getMessagesStatus` incorrect source

[sistemd]

The failure_reason field in starknet_getMessagesStatus (RPC version 0.9 and up) is incorrectly derived from finality status when it should be derived from the execution status.

Reference:
RPC v0.9: https://github.com/starkware-libs/starknet-specs/blob/release/v0.9.1-rc.0/api/starknet_api_openrpc.json#L285-L288
RPC v0.10: https://github.com/starkware-libs/starknet-specs/blob/release/v0.10.2/api/starknet_api_openrpc.json#L344-L347

[vbar]

Hmm, that isn't how I read the spec... "Only appears if execution_status is REVERTED"" doesn't necessarily mean the value is derived from execution status - rather, I'd say it's gated by the execution status...

[sistemd]

Where would it be derived from in that case? It can't be from the REJECTED variant of finality status because rejected transactions do not have an execution status.

[vbar]

Where would it be derived from in that case? It can't be from the REJECTED variant of finality status because rejected transactions do not have an execution status.

Hmm, that's a good argument... Looking at the previous specs, you're probably right - the failure reason used to be derived from finality status, but v09 switched it to execution status...