Updating library to more recent framework version

[timpoll]

I have updated the targets for the 3 projects. I am ready to push them if you would like.

[eramella]

Ok you can create a PR and I'll look into it.

[timpoll]

Emanuele, I’m not well experienced with GitHub. To get started, I cloned your repository. I made the changes and performed 2 commits. As I understand it, I need to push my changes to GitHub and then I can make a Pull Request. Is that right? When I try to push my commits to master, I’m getting this error: Pushing master Remote: Permission to eramella/QFXparser.git denied to timpoll. Error encountered while pushing to the remote repository: Git failed with a fatal error. Git failed with a fatal error. unable to access 'https://github.com/eramella/QFXparser.git/': The requested URL returned error: 403 Failed to push to the remote repository. See the Output window for more details. Do I need to clone the repo differently? Do I need edit permissions? Am I doing something wrong? Thanks Tim Poll From: Emanuele ***@***.***> Sent: Saturday, October 23, 2021 5:38 PM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [eramella/QFXparser] Projects Target .NET Core and .NET Standard 2.0 (Issue #10) Ok you can create a PR and I'll look into it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feramella%2FQFXparser%2Fissues%2F10%23issuecomment-950219388&data=04%7C01%7C%7Ca9e07ad73c414553771408d9966d7a62%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637706219213666317%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=EyhuovPjYVU928vHiEiRGMtGDVIMTsyrYcn8xwQs3Bc%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABWFUZXVUNC6CQ5NMA7M673UIMTN3ANCNFSM5GMFGQHQ&data=04%7C01%7C%7Ca9e07ad73c414553771408d9966d7a62%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637706219213676280%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=dBK%2FIGacaBcyCmqbNcYVhfNNflxscGlYmJZOAjSeTso%3D&reserved=0>. Triage notifications on the go with GitHub Mobile for iOS<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Ca9e07ad73c414553771408d9966d7a62%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637706219213676280%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=24Jl5zmldWVsZtNh%2F2B%2BUsr9kfbPqDVdEAdIYiJ6DeU%3D&reserved=0> or Android<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Ca9e07ad73c414553771408d9966d7a62%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637706219213686234%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=WU0RDXgreSwaK1lHg72M7S02qYI9tJXpBCB3oYUiGnA%3D&reserved=0>.

[eramella]

If I am not mistaken, you must first create your own branch (locally, check hot git works). Then you you push your branch to this repo. Once the branch is pushed I think you can submit a Pull Request to merge code into master.
If this does not work, fork my repo into your github account. Then apply your changes and submit a PR from you forked repo to mine.
I didn't do much research, sorry. I hope this work.

[eramella]

Check this official documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

[timpoll]

Awesome. I’ll take a look. Thanks! Tim Poll From: Emanuele ***@***.***> Sent: Sunday, October 31, 2021 12:19 AM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [eramella/QFXparser] Updating library to more recent framework version (Issue #10) Check this official documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.github.com%2Fen%2Fgithub%2Fcollaborating-with-pull-requests%2Fproposing-changes-to-your-work-with-pull-requests%2Fcreating-a-pull-request&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764226359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=q2OvQOVjCFkxEGjoVEau%2BcPVwZqL6e3emQVtuI96lec%3D&reserved=0> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feramella%2FQFXparser%2Fissues%2F10%23issuecomment-955634069&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764236316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LaA4LOz92OP%2Fs8BEeWEUZU11cweejNmzmq%2ByeM66ogk%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABWFUZW43Y32GD5IYNV7QETUJS7VNANCNFSM5GMFGQHQ&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764246275%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8%2BVj6rt6EONp6%2BBoJKr44oWSPmhp3z25oa82dmnUrDU%3D&reserved=0>. Triage notifications on the go with GitHub Mobile for iOS<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764256227%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vjj2T%2B7dbn07D7xHoicQcmm3zWQUVxb0uvrFFF9jxuY%3D&reserved=0> or Android<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764256227%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GgVOqmCIO%2FeCSlWW9Z0aXfsdmS%2F2pL6Ly582YGaQgmg%3D&reserved=0>.

[timpoll]

I created a branch, pushed my changes and created a pull request. Please let me know if everything looks okay on your side. If that goes good, I’ll upgrade the apps to .NET 5.0 and .NET Standard 2.1 and create another pull request. Thanks. Tim Poll From: Emanuele ***@***.***> Sent: Sunday, October 31, 2021 12:19 AM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [eramella/QFXparser] Updating library to more recent framework version (Issue #10) Check this official documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.github.com%2Fen%2Fgithub%2Fcollaborating-with-pull-requests%2Fproposing-changes-to-your-work-with-pull-requests%2Fcreating-a-pull-request&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764226359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=q2OvQOVjCFkxEGjoVEau%2BcPVwZqL6e3emQVtuI96lec%3D&reserved=0> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feramella%2FQFXparser%2Fissues%2F10%23issuecomment-955634069&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764236316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LaA4LOz92OP%2Fs8BEeWEUZU11cweejNmzmq%2ByeM66ogk%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABWFUZW43Y32GD5IYNV7QETUJS7VNANCNFSM5GMFGQHQ&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764246275%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8%2BVj6rt6EONp6%2BBoJKr44oWSPmhp3z25oa82dmnUrDU%3D&reserved=0>. Triage notifications on the go with GitHub Mobile for iOS<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764256227%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vjj2T%2B7dbn07D7xHoicQcmm3zWQUVxb0uvrFFF9jxuY%3D&reserved=0> or Android<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764256227%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GgVOqmCIO%2FeCSlWW9Z0aXfsdmS%2F2pL6Ly582YGaQgmg%3D&reserved=0>.

[timpoll]

Hello, Have you had a chance to review my pull request? Tim Poll From: Tim ***@***.***> Sent: Tuesday, November 2, 2021 7:01 AM To: ***@***.***> Subject: RE: [eramella/QFXparser] Updating library to more recent framework version (Issue #10) I created a branch, pushed my changes and created a pull request. Please let me know if everything looks okay on your side. If that goes good, I’ll upgrade the apps to .NET 5.0 and .NET Standard 2.1 and create another pull request. Thanks. Tim Poll From: Emanuele ***@***.***> Sent: Sunday, October 31, 2021 12:19 AM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [eramella/QFXparser] Updating library to more recent framework version (Issue #10) Check this official documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.github.com%2Fen%2Fgithub%2Fcollaborating-with-pull-requests%2Fproposing-changes-to-your-work-with-pull-requests%2Fcreating-a-pull-request&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764226359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=q2OvQOVjCFkxEGjoVEau%2BcPVwZqL6e3emQVtuI96lec%3D&reserved=0> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feramella%2FQFXparser%2Fissues%2F10%23issuecomment-955634069&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764236316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LaA4LOz92OP%2Fs8BEeWEUZU11cweejNmzmq%2ByeM66ogk%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABWFUZW43Y32GD5IYNV7QETUJS7VNANCNFSM5GMFGQHQ&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764246275%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=8%2BVj6rt6EONp6%2BBoJKr44oWSPmhp3z25oa82dmnUrDU%3D&reserved=0>. Triage notifications on the go with GitHub Mobile for iOS<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764256227%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vjj2T%2B7dbn07D7xHoicQcmm3zWQUVxb0uvrFFF9jxuY%3D&reserved=0> or Android<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Ca3e0bdd2565749054f0308d99c25a584%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712507764256227%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GgVOqmCIO%2FeCSlWW9Z0aXfsdmS%2F2pL6Ly582YGaQgmg%3D&reserved=0>.

[cobrien666]

Looks like the project is still using NetStandard 2. Has there been any work done to upgrade to a new version of the framework?